diff --git a/src/applications/people/storage/PhabricatorUser.php b/src/applications/people/storage/PhabricatorUser.php --- a/src/applications/people/storage/PhabricatorUser.php +++ b/src/applications/people/storage/PhabricatorUser.php @@ -568,29 +568,6 @@ return $this->getUserSetting(PhabricatorPronounSetting::SETTINGKEY); } - public function loadPreferences() { - if ($this->preferences) { - return $this->preferences; - } - - $preferences = null; - if ($this->getPHID()) { - $preferences = id(new PhabricatorUserPreferencesQuery()) - ->setViewer($this) - ->withUsers(array($this)) - ->executeOne(); - } - - if (!$preferences) { - $preferences = new PhabricatorUserPreferences(); - $preferences->setUserPHID($this->getPHID()); - $preferences->attachUser($this); - } - - $this->preferences = $preferences; - return $preferences; - } - public function loadEditorLink( $path, $line, diff --git a/src/applications/settings/storage/PhabricatorUserPreferences.php b/src/applications/settings/storage/PhabricatorUserPreferences.php --- a/src/applications/settings/storage/PhabricatorUserPreferences.php +++ b/src/applications/settings/storage/PhabricatorUserPreferences.php @@ -98,16 +98,6 @@ return false; } - // TODO: Remove this once all edits go through the Editor. For now, some - // old edits just do direct saves so make sure we nuke the cache. - public function save() { - PhabricatorUserCache::clearCache( - PhabricatorUserPreferencesCacheType::KEY_PREFERENCES, - $this->getUserPHID()); - - return parent::save(); - } - /** * Load or create a preferences object for the given user. *