Page MenuHomePhabricator

Prepare UserPreferences for transactions
ClosedPublic

Authored by epriestley on May 31 2016, 3:35 PM.
Tags
None
Referenced Files
F13059746: D15991.diff
Fri, Apr 19, 4:45 PM
Unknown Object (File)
Thu, Apr 11, 9:54 AM
Unknown Object (File)
Sun, Apr 7, 11:17 AM
Unknown Object (File)
Tue, Apr 2, 9:57 AM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Unknown Object (File)
Sun, Mar 31, 11:36 PM
Unknown Object (File)
Sat, Mar 30, 2:01 AM
Unknown Object (File)
Wed, Mar 27, 6:08 PM
Subscribers
None

Details

Summary

Ref T4103. This give preferences a PHID, policy/transaction interfaces, a transaction table, and a Query class.

This doesn't actually change how they're edited, yet.

Test Plan
  • Ran migrations.
  • Inspected database for date created, date modified, PHIDs.
  • Changed some of my preferences.
  • Deleted a user's preferences, verified they reset properly.
  • Set some preferences as a new user, got a new row.
  • Destroyed a user, verified their preferences were destroyed.
  • Sent Conpherence messages.
  • Send mail.
  • Tried to edit another user's settings.
  • Tried to edit a bot's settings as a non-admin.
  • Edited a bot's settings as an admin (technically, none of the editable settings are actually stored in the settings table, currently).

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Prepare UserPreferences for transactions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 31 2016, 3:51 PM
This revision was automatically updated to reflect the committed changes.