Page MenuHomePhabricator

SVN buildSyntheticAdditionDiff: exit sooner if path is a directory
ClosedPublic

Authored by allanjude on May 29 2016, 10:12 PM.
Referenced Files
F14962277: D15985.id.diff
Sun, Feb 16, 6:53 AM
Unknown Object (File)
Wed, Feb 12, 6:58 AM
Unknown Object (File)
Sun, Feb 9, 1:41 AM
Unknown Object (File)
Sun, Feb 9, 1:40 AM
Unknown Object (File)
Sun, Feb 9, 1:40 AM
Unknown Object (File)
Mon, Feb 3, 9:13 PM
Unknown Object (File)
Sun, Feb 2, 11:45 AM
Unknown Object (File)
Thu, Jan 30, 3:43 AM
Subscribers

Details

Summary

When doing svn copy, or svn mv, a SynthenticAdditionDiff is generated.

If the path is a directory, an error will occur when checking the
mime-type of the directory. Immediately after the properties check,
the function returns null if the path is a directory. Move this
check to before the properties check to avoid exiting with an error.

Command failed with error #1!
COMMAND
svn propget 'svn:mime-type' '/home/trasz/svn/ports/cad/py-pycam'@

STDOUT
(empty)

STDERR
svn: warning: W200017: Property 'svn:mime-type' not found on '/home/trasz/svn/ports/cad/py-pycam@'
svn: E200000: A problem occurred; see other errors for details

(Run with `--trace` for a full exception trace.)
Test Plan

Created differentials of changes with svn copy and svn mv

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

allanjude retitled this revision from to SVN buildSyntheticAdditionDiff: exit sooner if path is a directory.
allanjude updated this object.
allanjude edited the test plan for this revision. (Show Details)
epriestley removed a task: Restricted Maniphest Task.Jun 1 2016, 12:25 PM
This revision is now accepted and ready to land.Jun 5 2016, 10:12 PM
This revision was automatically updated to reflect the committed changes.