Page MenuHomePhabricator

Use transactions to apply web UI SSH key edits
ClosedPublic

Authored by epriestley on May 19 2016, 5:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 30, 12:36 PM
Unknown Object (File)
Fri, Sep 30, 12:17 AM
Unknown Object (File)
Wed, Sep 28, 9:42 AM
Unknown Object (File)
Tue, Sep 27, 10:36 PM
Unknown Object (File)
Mon, Sep 26, 7:56 AM
Unknown Object (File)
Sun, Sep 25, 9:20 PM
Unknown Object (File)
Sat, Sep 24, 6:49 AM
Unknown Object (File)
Fri, Sep 23, 7:08 PM
Subscribers
None

Details

Summary

Ref T10917. Converts web UI edits to transactions.

This is about 95% "the right way", and then I cheated on the last 5% instead of building a real EditEngine. We don't need it for anything else right now and some of the dialog workflows here are a little weird so I'm just planning to skip it for the moment unless it ends up being easier to do after the next phase (mail notifications) or something like that.

Test Plan

Screen Shot 2016-05-19 at 10.12.48 AM.png (1×1 px, 157 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Use transactions to apply web UI SSH key edits.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.May 19 2016, 9:50 PM
This revision was automatically updated to reflect the committed changes.