Differential D15895
Modernize PhpunitTestEngine to work with .arcunit Authored by Firehed on May 12 2016, 1:04 AM. Tags None Referenced Files
Subscribers Tokens
Details
Updates the configuration process of PHPUnit test engine to support .arcunit-driven setup. Adds a bit of additional infrastructure so other Unit engines can indicate their configuration needs. Works towards T5568, and depends on (well, technically includes) D15880.
other than running the unit tests on this project, I ran arc unit on two other projects: one with a unit engine configured in .arcconfig, and a second with the following .arcunit file: { "engines": { "phpunit": { "type": "phpunit", "include": "(\\.php$)", "flags": { "--whitelist": "$ROOT/src", "--include-path": "~/dev" }, "binary": "vendor/bin/phpunit" } } } I observed the desired unit test commands being run in the trace output
Diff Detail
Event TimelineComment Actions I'd like to get some feedback on the initial implementation, I'll go back and address the couple of TODOs. Note that the change to PhutilUnitTestEngine and one change in ArcanistConfigurationDrivenUnitEngine are actually D15880 because I branched from the wrong place. Comment Actions Noted. This is by no means an urgent thing (I have a Composer package to mostly the same effect, it just seems silly to be maintaining it twice), and all else being equal I'd rather spend time thinking about the bigger solution. But in the name of all things holy, please don't reinvent Composer as T5055 is basically getting at. |