Page MenuHomePhabricator
Differential D15846

Generate syntax highlighting CSS from a reusable map
ClosedPublic
Actions

Authored by epriestley on May 5 2016, 1:28 AM.
Tags
None
Referenced Files
F15400173: D15846.id.diff
Mon, Mar 17, 10:06 AM
F15397007: D15846.diff
Sun, Mar 16, 5:35 PM
F15381068: D15846.diff
Fri, Mar 14, 5:44 AM
F15378338: D15846.id38183.diff
Thu, Mar 13, 1:52 PM
Unknown Object (File)
Mon, Mar 3, 1:29 AM
Unknown Object (File)
Mon, Feb 24, 6:29 AM
Unknown Object (File)
Feb 16 2025, 10:33 AM
Unknown Object (File)
Feb 16 2025, 6:46 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments
Commits
rP01289f3f486a: Generate syntax highlighting CSS from a reusable map
Summary

Ref T9790. This prepares the syntax color rules to be reused in mail.

This goes about halfway toward T5701 by sort-of supporting different styles but not really.

Test Plan
  • Ran bin/celerity syntax to regenerate syntax map.
  • Viewed some highlighted code, didn't see any differences.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38174.May 5 2016, 1:28 AM
epriestley retitled this revision from to Generate syntax highlighting CSS from a reusable map.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T9790: HTML email doesn't syntax highlight code blocks, inline diffs, or diff context above inline comments.
Herald edited edge metadata. · View Herald TranscriptMay 5 2016, 1:28 AM
chad accepted this revision.May 5 2016, 1:32 AM
chad edited edge metadata.
This revision is now accepted and ready to land.May 5 2016, 1:32 AM
Closed by commit rP01289f3f486a: Generate syntax highlighting CSS from a reusable map (authored by epriestley, committed by epriestley). · Explain WhyMay 5 2016, 9:50 AM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10694: Improve behavior of context for inline comments in mail.May 5 2016, 6:55 PM
chad added a comment.Jul 18 2017, 10:59 PM

hmmm

chad added a comment.Jul 18 2017, 11:01 PM

this is cramping my style

Revision Contents
Changeset List

PathSize
resources/
celerity/
12 lines
1 line
src/
6 lines
applications/
celerity/
management/
67 lines
infrastructure/
syntax/
76 lines
30 lines
webroot/
rsrc/
css/
core/
105 lines
syntax/
150 lines

Diff 38183

View Options

resources/celerity/map.php

Loading...
View Options

resources/celerity/packages.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/celerity/management/CelerityManagementSyntaxWorkflow.php

Loading...
View Options

src/infrastructure/syntax/PhabricatorDefaultSyntaxStyle.php

Loading...
View Options

src/infrastructure/syntax/PhabricatorSyntaxStyle.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
View Options

webroot/rsrc/css/syntax/syntax-default.css

Loading...
Phabricator · Built by Phacility