Page MenuHomePhabricator
Differential D15816

Add repository URI view pages and IO/Display edit logic
ClosedPublic
Actions

Authored by epriestley on Apr 28 2016, 5:45 PM.
Tags
None
Referenced Files
F14732017: D15816.id38097.diff
Sat, Jan 18, 1:25 PM
F14730735: D15816.id38097.diff
Sat, Jan 18, 7:42 AM
F14730462: D15816.diff
Sat, Jan 18, 7:32 AM
F14728650: D15816.diff
Sat, Jan 18, 5:47 AM
Unknown Object (File)
Fri, Jan 17, 4:54 PM
Unknown Object (File)
Thu, Jan 2, 7:32 PM
Unknown Object (File)
Tue, Dec 31, 9:00 AM
Unknown Object (File)
Thu, Dec 26, 10:59 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API
Commits
rPc8711da5ffbf: Add repository URI view pages and IO/Display edit logic
Summary

Ref T10748.

  • New View page for repository URIs.
  • Make display and I/O behavior (observe, mirror, read, read/write) editable.
  • Add a bunch of checks to prevent you from completely screwing up a repository by making it writable from a bunch of differnet sources.
Test Plan

Screen Shot 2016-04-28 at 10.39.35 AM.png (1×1 px, 224 KB)

Screen Shot 2016-04-28 at 10.42.21 AM.png (1×1 px, 148 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 38097.Apr 28 2016, 5:45 PM
epriestley retitled this revision from to Add repository URI view pages and IO/Display edit logic.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.
chad accepted this revision.Apr 29 2016, 1:03 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2016, 1:03 AM
Closed by commit rPc8711da5ffbf: Add repository URI view pages and IO/Display edit logic (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2016, 4:23 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T10748: Implement `diffusion.repository.edit`, for creating and editing repositories via the API.Apr 30 2016, 12:43 AM

Revision Contents
Changeset List

Diff 38115

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/application/PhabricatorDiffusionApplication.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionRepositoryURIViewController.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionURIEditEngine.php

Loading...
View Options

src/applications/diffusion/editor/DiffusionURIEditor.php

Loading...
View Options

src/applications/diffusion/management/DiffusionRepositoryURIsManagementPanel.php

Loading...
View Options

src/applications/repository/query/PhabricatorRepositoryURITransactionQuery.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURI.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryURITransaction.php

Loading...
Phabricator · Built by Phacility