Page MenuHomePhabricator

Give application actors in feed reasonable icons
ClosedPublic

Authored by epriestley on Apr 20 2016, 9:27 PM.

Details

Summary

Ref T8952. Currently, when an application (most commonly Herald, but sometimes Drydock, Diffusion, etc) publishes a feed story, we get an empty grey box for it in feed.

Instead, give the story a little application icon kind of "profile picture"-like thing.

Test Plan

Here's how it looks:

Screen Shot 2016-04-20 at 2.24.07 PM.png (153×362 px, 13 KB)

Feel free to tweak/counter-diff.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Give application actors in feed reasonable icons.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
chad added inline comments.
webroot/rsrc/css/phui/phui-feed-story.css
19

can probably kill this now if everything has an icon/image

This revision is now accepted and ready to land.Apr 20 2016, 9:36 PM

I think (?) it looks better with it -- at least, the application icons do -- but feel free to shoot me an update if you want to nuke it.

This revision was automatically updated to reflect the committed changes.