Page MenuHomePhabricator
Differential D15767

Fix Phriction document linking in mail bodies
ClosedPublic
Actions

Authored by epriestley on Apr 20 2016, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 2:47 PM
Unknown Object (File)
Mon, Apr 15, 11:14 PM
Unknown Object (File)
Sat, Apr 13, 9:44 PM
Unknown Object (File)
Wed, Apr 3, 11:26 PM
Unknown Object (File)
Mon, Apr 1, 3:15 AM
Unknown Object (File)
Mon, Apr 1, 3:15 AM
Unknown Object (File)
Mon, Apr 1, 3:15 AM
Unknown Object (File)
Mon, Apr 1, 3:15 AM
View All Files
Subscribers
None

Details

Reviewers
hach-que
chad
Maniphest Tasks
T10840: Phriction documents don't link correctly in mail
Commits
rP11f8fffe5bb7: Fix Phriction document linking in mail bodies
Summary

Fixes T10840. When rendering mail, this rule wasn't falling through in quite the right way.

Also adjust where the rules are for this so the special styles show up in Maniphest, etc.

Test Plan

Made this comment:

Screen Shot 2016-04-20 at 6.06.08 AM.png (330×579 px, 22 KB)

Which produced this HTML:

Screen Shot 2016-04-20 at 6.06.04 AM.png (228×614 px, 25 KB)

...and sent this mail:

Screen Shot 2016-04-20 at 6.05.54 AM.png (772×1 px, 93 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37988.Apr 20 2016, 1:09 PM
epriestley retitled this revision from to Fix Phriction document linking in mail bodies.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10840: Phriction documents don't link correctly in mail.
Herald edited edge metadata. · View Herald TranscriptApr 20 2016, 1:09 PM
epriestley edited the test plan for this revision. (Show Details)Apr 20 2016, 1:13 PM
epriestley edited edge metadata.
epriestley added a reviewer: hach-que.
chad accepted this revision.Apr 20 2016, 1:43 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2016, 1:43 PM
Closed by commit rP11f8fffe5bb7: Fix Phriction document linking in mail bodies (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2016, 1:55 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
src/
applications/
phriction/
markup/
16 lines
webroot/
rsrc/
css/
application/
phriction/
14 lines
core/
12 lines

Diff 37989

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Loading...
View Options

webroot/rsrc/css/application/phriction/phriction-document-css.css

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
Phabricator · Built by Phacility