Ref T7691 (errata). This shows links to Phriction documents in red if they're missing, and links to Phriction documents in grey with a lock icon if the user doesn't have the correct permissions to see the document.
Details
Details
- Reviewers
epriestley chad - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7691: Relative wiki links
- Commits
- rP27227b8010ee: Show missing Phriction documents as red links, invisible documents with a lock
Tested a bunch of different configurations:
[[ ./../ ]] Back to Main Document [[ ./../subdocument_2]] Mmmm more documents [[ ./../invisible_document]] Mmmm more documents [[ ./../ | Explicit Title ]] Back to Main Document [[ ./../subdocument_2 | Explicit Title ]] Mmmm more documents [[ ./../invisible_document | Explicit Title ]] Mmmm more documents [[ ]] Absolute link [[ subdocument_2 ]] Absolute link [[ invisible_document ]] Absolute link [[ | Explicit Title ]] Absolute link [[ subdocument_2 | Explicit Title ]] Absolute link [[ invisible_document | Explicit Title ]] Absolute link
Got the expected result:
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- titles-and-things
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 11785 Build 14774: Run Core Tests Build 14773: arc lint + arc unit
Event Timeline
| webroot/rsrc/css/application/phriction/phriction-document-css.css | ||
|---|---|---|
| 48 | I don't think strikethrough means 'no-permissions', it usually means closed/inactive/deleted. Probably no text-decoration might be better? | |
| webroot/rsrc/css/application/phriction/phriction-document-css.css | ||
|---|---|---|
| 48 | oh yeah i'm a derp | |
Comment Actions
Vague stylistic nitpicks inline, thanks for fixing this stuff!
| src/applications/phriction/markup/PhrictionRemarkupRule.php | ||
|---|---|---|
| 66–68 | Maybe simpler as: $link = rtrim($link, '/').'/'; | |
| 137–144 | You can omit null as the third parameter to idx(), since it's the default. | |
| 154 | This should just be $visible_documents[$link] I think? | |