Page MenuHomePhabricator
Differential D15706

Make Git prompt for passwords when the user provides a username but not a password
ClosedPublic
Actions

Authored by epriestley on Apr 14 2016, 12:10 AM.

Details

Reviewers
chad
Maniphest Tasks
T10797: Git HTTP operations fail with username in URL
Commits
rPc0428b4d6dd0: Make Git prompt for passwords when the user provides a username but not a…
Summary

Fixes T10797. This seems to fix things on my local system.

Test Plan
  • Cloned with a username, got prompted for a password.
  • Cloned with a username + password.
  • Cloned with a username + bad password (error).

Diff Detail

Repository
rP Phabricator
Branch
userpass
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11705
Build 14661: Run Core Tests
Build 14660: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37837.Apr 14 2016, 12:10 AM
epriestley retitled this revision from to Make Git prompt for passwords when the user provides a username but not a password.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10797: Git HTTP operations fail with username in URL.
Grimeh added a subscriber: Grimeh.Apr 14 2016, 12:24 AM
chad accepted this revision.Apr 14 2016, 1:59 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 14 2016, 1:59 AM
Closed by commit rPc0428b4d6dd0: Make Git prompt for passwords when the user provides a username but not a… (authored by epriestley, committed by epriestley). · Explain WhyApr 14 2016, 1:59 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
9 lines

Diff 37837

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
Phabricator · Built by Phacility