Page MenuHomePhabricator

Never sever non-cluster database; write more read-only documentation
ClosedPublic

Authored by epriestley on Apr 11 2016, 1:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 4:53 AM
Unknown Object (File)
Mon, Dec 9, 3:59 AM
Unknown Object (File)
Sun, Dec 8, 11:44 PM
Unknown Object (File)
Tue, Nov 26, 11:53 AM
Unknown Object (File)
Thu, Nov 21, 12:43 AM
Unknown Object (File)
Nov 20 2024, 4:58 AM
Unknown Object (File)
Nov 16 2024, 9:56 PM
Unknown Object (File)
Nov 13 2024, 1:44 AM
Subscribers
None

Details

Summary

Ref T4571. Write more of the missing documentation sections and clarify a few things.

Since the "replicating master" check needs a special permission, imposes a performance penalty, is probably very difficult to misconfigure, and likely not a big deal anyway, just drop the idea of trying to automatically detect + prevent it. We still show if it's an issue on the status page, provided we have permission to check.

When you don't have any cluster databases configured, never stop trying to connect to the default master database. We might want to do this eventually as load reduction, but just don't muddy the waters too much for now while things stabilize.

Test Plan
  • Tested functionality in cluster, non-cluster, and degraded-cluster modes.
  • Used status console to monitor a health check cycle.
  • Read docs.

Diff Detail

Repository
rP Phabricator
Branch
readonly13
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11649
Build 14573: Run Core Tests
Build 14572: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Never sever non-cluster database; write more read-only documentation.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Apr 11 2016, 3:42 PM
This revision was automatically updated to reflect the committed changes.