Page MenuHomePhabricator
Differential D15664

Increase specificity in blue property boxes
ClosedPublic
Actions

Authored by chad on Apr 9 2016, 5:01 PM.
Tags
None
Referenced Files
F15459152: D15664.id.diff
Mon, Mar 31, 10:15 AM
F15455823: D15664.diff
Sun, Mar 30, 5:02 AM
F15433468: D15664.id.diff
Mon, Mar 24, 11:22 PM
F15429045: D15664.diff
Mon, Mar 24, 12:08 AM
F15427389: D15664.id37749.diff
Sun, Mar 23, 2:09 PM
F15390549: D15664.id37750.diff
Sat, Mar 15, 6:19 AM
F15361601: D15664.id37750.diff
Tue, Mar 11, 12:34 PM
Unknown Object (File)
Mar 3 2025, 10:44 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Group Reviewers
Phacility
Maniphest Tasks
T10757: Countdowns embedded in Phriction pages pick up excessive margins/padding
Commits
rPdb065e67582e: Increase specificity in blue property boxes
Summary

Feels a little hairy, but should be fine overall. Ups the css specificity enough that it's always displayed the same. The main problem is headers and boxes get put everywhere, and sometimes override each other. Fixes T10757

Test Plan

review a countdown in a phame post and phriction document. Check diviner, phriction for regressions.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37749.Apr 9 2016, 5:01 PM
chad retitled this revision from to Increase specificity in blue property boxes.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10757: Countdowns embedded in Phriction pages pick up excessive margins/padding.
Herald added a subscriber: Korvin. · View Herald TranscriptApr 9 2016, 5:01 PM
chad updated this revision to Diff 37750.Apr 9 2016, 5:07 PM
  • check with description
epriestley accepted this revision.Apr 21 2016, 2:34 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 21 2016, 2:34 AM
chad added a reviewer: Phacility.Apr 27 2016, 7:49 PM
Closed by commit rPdb065e67582e: Increase specificity in blue property boxes (authored by chad, committed by chad). · Explain WhyMay 4 2016, 12:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
10 lines
webroot/
rsrc/
css/
application/
countdown/
14 lines
phui/
5 lines

Diff 38157

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/application/countdown/timer.css

Loading...
View Options

webroot/rsrc/css/phui/phui-box.css

Loading...
Phabricator · Built by Phacility