Page MenuHomePhabricator
Differential D15556

Clean up EditEngine implementation on Badges
ClosedPublic
Actions

Authored by chad on Apr 1 2016, 12:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 9:28 AM
Unknown Object (File)
Fri, Nov 22, 5:22 PM
Unknown Object (File)
Thu, Nov 21, 5:02 PM
Unknown Object (File)
Mon, Nov 18, 10:37 AM
Unknown Object (File)
Wed, Nov 13, 5:27 PM
Unknown Object (File)
Sun, Nov 10, 3:32 PM
Unknown Object (File)
Wed, Nov 6, 4:05 PM
Unknown Object (File)
Tue, Nov 5, 2:42 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
lpriestley
Maniphest Tasks
T10672: Complete EditEngine implementation in Badges
Commits
rP154234dd1f04: Clean up EditEngine implementation on Badges
Summary

Fixes T10672. Cleaning this up myself since I was responsible for the implementation.

Test Plan

Leave a comment, Edit a badge, create a badge.

Diff Detail

Repository
rP Phabricator
Branch
badges-edit-engine-2 (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11372
Build 14159: Run Core Tests
Build 14158: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 37507.Apr 1 2016, 12:31 AM
chad retitled this revision from to Clean up EditEngine implementation on Badges.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, lpriestley.
chad added a task: T10672: Complete EditEngine implementation in Badges.
Herald added a subscriber: Korvin. · View Herald TranscriptApr 1 2016, 12:31 AM
epriestley accepted this revision.Apr 1 2016, 12:32 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2016, 12:32 AM
Closed by commit rP154234dd1f04: Clean up EditEngine implementation on Badges (authored by chad, committed by chad). · Explain WhyApr 1 2016, 12:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
application/
4 lines
controller/
13 lines
26 lines
editor/
17 lines

Diff 37507

View Options

src/applications/badges/application/PhabricatorBadgesApplication.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesListController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/badges/editor/PhabricatorBadgesEditEngine.php

Loading...
Phabricator · Built by Phacility