diff --git a/src/applications/differential/controller/DifferentialChangesetViewController.php b/src/applications/differential/controller/DifferentialChangesetViewController.php --- a/src/applications/differential/controller/DifferentialChangesetViewController.php +++ b/src/applications/differential/controller/DifferentialChangesetViewController.php @@ -275,6 +275,7 @@ ->setRenderURI('/differential/changeset/') ->setDiff($diff) ->setTitle(pht('Standalone View')) + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setParser($parser); if ($revision_id) { @@ -296,16 +297,20 @@ } $crumbs->addTextCrumb($changeset->getDisplayFilename()); + $crumbs->setBorder(true); - return $this->buildApplicationPage( - array( - $crumbs, - $detail, - ), - array( - 'title' => pht('Changeset View'), - 'device' => false, - )); + $header = id(new PHUIHeaderView()) + ->setHeader(pht('Changeset View')) + ->setHeaderIcon('fa-gear'); + + $view = id(new PHUITwoColumnView()) + ->setHeader($header) + ->setFooter($detail); + + return $this->newPage() + ->setTitle(pht('Changeset View')) + ->setCrumbs($crumbs) + ->appendChild($view); } private function buildRawFileResponse( diff --git a/src/applications/differential/controller/DifferentialDiffCreateController.php b/src/applications/differential/controller/DifferentialDiffCreateController.php --- a/src/applications/differential/controller/DifferentialDiffCreateController.php +++ b/src/applications/differential/controller/DifferentialDiffCreateController.php @@ -124,10 +124,12 @@ $title = pht('Update Diff'); $header = pht('Update Diff'); $button = pht('Continue'); + $header_icon = 'fa-upload'; } else { $title = pht('Create Diff'); $header = pht('Create New Diff'); $button = pht('Create Diff'); + $header_icon = 'fa-plus-square'; } $form @@ -180,15 +182,12 @@ ->setValue($button)); $form_box = id(new PHUIObjectBoxView()) - ->setHeaderText($header) + ->setHeaderText(pht('Diff')) ->setValidationException($validation_exception) ->setForm($form) + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setFormErrors($errors); - if ($info_view) { - $form_box->setInfoView($info_view); - } - $crumbs = $this->buildApplicationCrumbs(); if ($revision) { $crumbs->addTextCrumb( @@ -196,15 +195,23 @@ '/'.$revision->getMonogram()); } $crumbs->addTextCrumb($title); + $crumbs->setBorder(true); - return $this->buildApplicationPage( - array( - $crumbs, + $header = id(new PHUIHeaderView()) + ->setHeader($title) + ->setHeaderIcon($header_icon); + + $view = id(new PHUITwoColumnView()) + ->setHeader($header) + ->setFooter(array( + $info_view, $form_box, - ), - array( - 'title' => $title, )); + + return $this->newPage() + ->setTitle($title) + ->setCrumbs($crumbs) + ->appendChild($view); } } diff --git a/src/applications/differential/controller/DifferentialRevisionEditController.php b/src/applications/differential/controller/DifferentialRevisionEditController.php --- a/src/applications/differential/controller/DifferentialRevisionEditController.php +++ b/src/applications/differential/controller/DifferentialRevisionEditController.php @@ -171,35 +171,44 @@ $crumbs = $this->buildApplicationCrumbs(); if ($revision->getID()) { if ($diff) { + $header_icon = 'fa-upload'; $title = pht('Update Differential Revision'); $crumbs->addTextCrumb( 'D'.$revision->getID(), '/differential/diff/'.$diff->getID().'/'); } else { + $header_icon = 'fa-pencil'; $title = pht('Edit Differential Revision'); $crumbs->addTextCrumb( 'D'.$revision->getID(), '/D'.$revision->getID()); } } else { + $header_icon = 'fa-plus-square'; $title = pht('Create New Differential Revision'); } $form_box = id(new PHUIObjectBoxView()) - ->setHeaderText($title) + ->setHeaderText('Revision') ->setValidationException($validation_exception) + ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY) ->setForm($form); $crumbs->addTextCrumb($title); + $crumbs->setBorder(true); - return $this->buildApplicationPage( - array( - $crumbs, - $form_box, - ), - array( - 'title' => $title, - )); + $header = id(new PHUIHeaderView()) + ->setHeader($title) + ->setHeaderIcon($header_icon); + + $view = id(new PHUITwoColumnView()) + ->setHeader($header) + ->setFooter($form_box); + + return $this->newPage() + ->setTitle($title) + ->setCrumbs($crumbs) + ->appendChild($view); } }