Page MenuHomePhabricator
Differential D15547

Fix translation of badge feed stories.
ClosedPublic
Actions

Authored by lpriestley on Mar 29 2016, 5:38 PM.
Tags
None
Referenced Files
F14411658: D15547.diff
Tue, Dec 24, 12:00 PM
Unknown Object (File)
Fri, Dec 20, 4:41 PM
Unknown Object (File)
Sat, Dec 7, 7:35 AM
Unknown Object (File)
Sat, Dec 7, 12:28 AM
Unknown Object (File)
Tue, Dec 3, 5:45 PM
Unknown Object (File)
Tue, Dec 3, 12:33 AM
Unknown Object (File)
Mon, Dec 2, 5:21 AM
Unknown Object (File)
Wed, Nov 27, 4:31 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10688: Badge translation error
Commits
rP8d67629e9ec0: Fix translation of badge feed stories.
Summary

Fixes T10688

Test Plan

Award badge, view main Feed

Diff Detail

Repository
rP Phabricator
Branch
badgestranslation
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11347
Build 14122: Run Core Tests
Build 14121: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37482.Mar 29 2016, 5:38 PM
lpriestley retitled this revision from to Fix translation of badge feed stories..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added reviewers: epriestley, chad.
lpriestley added a task: T10688: Badge translation error.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 29 2016, 5:38 PM
Herald added a subscriber: Korvin. · View Herald Transcript
chad accepted this revision.Mar 29 2016, 5:46 PM
chad edited edge metadata.
epriestley added a comment.Mar 29 2016, 5:48 PM

@chad, do we need H141? Was that just a test rule? I shouldn't really need to review this since you did, but it made me a blocking reviewer. :3

epriestley removed a reviewer: epriestley.Mar 29 2016, 5:48 PM
This revision is now accepted and ready to land.Mar 29 2016, 5:48 PM
epriestley added a reviewer: epriestley.Mar 29 2016, 5:48 PM
epriestley edited edge metadata.

It's also possible that I wrote that rule, but I don't remember if I did.

(At HEAD, it would have an edit history.)

chad added a comment.Mar 29 2016, 5:49 PM

no idea when or why I made that.

epriestley added a comment.Mar 29 2016, 5:51 PM

Haha, okay. I disabled it, and that generated a nice transaction.

lpriestley added a comment.Mar 29 2016, 5:54 PM

Also... I added Chad this time

chad added a comment.Mar 29 2016, 5:55 PM

My only thought is it was meant to catch cases someone only added me as a reviewer, before we had blocking reviewers?

chad added a comment.Mar 29 2016, 5:55 PM

shruggie

epriestley added a comment.Mar 29 2016, 5:56 PM

I think the "Blessed Reviewers" rule predates it, I bet it was someone creating a rule to try to test out one of the T731-style workarounds. But it could easily have been me just thinking I was on my local install. I'll peek in the database but I don't think we store anything useful and I'm not going to bother digging up the access logs.

Closed by commit rP8d67629e9ec0: Fix translation of badge feed stories. (authored by lpriestley, committed by lpriestley). · Explain WhyMar 29 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
internationalization/
translation/
12 lines

Diff 37482

View Options

src/infrastructure/internationalization/translation/PhabricatorUSEnglishTranslation.php

Loading...
Phabricator · Built by Phacility