Page MenuHomePhabricator
Differential D15539

Add a Nuance content source, and make use of it
ClosedPublic
Actions

Authored by epriestley on Mar 28 2016, 6:35 PM.
Tags
None
Referenced Files
F13059493: D15539.diff
Fri, Apr 19, 4:21 PM
Unknown Object (File)
Wed, Apr 17, 3:06 PM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Thu, Apr 11, 1:15 PM
Unknown Object (File)
Thu, Apr 11, 7:16 AM
Unknown Object (File)
Mon, Apr 1, 7:22 AM
Unknown Object (File)
Sat, Mar 30, 12:33 PM
Unknown Object (File)
Tue, Mar 26, 11:00 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10537: Nuance Infrastructure
Commits
rPf9306c2e58db: Add a Nuance content source, and make use of it
Summary

Ref T10537. Add a new content source for Nuance. Prepare for better author attribution.

Test Plan

Screen Shot 2016-03-28 at 11.31.39 AM.png (150×245 px, 8 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance27
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/nuance/item/NuanceGitHubEventItemType.php:365XHP63Useless Overriding Method
Advicesrc/applications/nuance/item/NuanceGitHubEventItemType.php:366XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 11324
Build 14087: Run Core Tests
Build 14086: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37459.Mar 28 2016, 6:35 PM
epriestley retitled this revision from to Add a Nuance content source, and make use of it.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10537: Nuance Infrastructure.
Herald edited edge metadata. · View Herald TranscriptMar 28 2016, 6:35 PM
chad accepted this revision.Mar 28 2016, 7:30 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2016, 7:30 PM
Closed by commit rPf9306c2e58db: Add a Nuance content source, and make use of it (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2016, 7:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
nuance/
contentsource/
16 lines
item/
19 lines
15 lines

Diff 37459

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/nuance/contentsource/NuanceContentSource.php

Loading...
View Options

src/applications/nuance/item/NuanceGitHubEventItemType.php

Loading...
View Options

src/applications/nuance/item/NuanceItemType.php

Loading...
Phabricator · Built by Phacility