Page MenuHomePhabricator
Differential D15537

Allow Nuance items to provide curtain panels, link to imported tasks, parse comments
ClosedPublic
Actions

Authored by epriestley on Mar 28 2016, 6:00 PM.
Tags
None
Referenced Files
F15400474: D15537.diff
Mon, Mar 17, 11:51 AM
F15382657: D15537.diff
Fri, Mar 14, 1:40 PM
Unknown Object (File)
Wed, Feb 26, 2:10 PM
Unknown Object (File)
Tue, Feb 25, 11:56 AM
Unknown Object (File)
Sun, Feb 16, 6:34 AM
Unknown Object (File)
Feb 9 2025, 1:07 AM
Unknown Object (File)
Feb 9 2025, 1:06 AM
Unknown Object (File)
Feb 9 2025, 1:06 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10537: Nuance Infrastructure
Commits
rPda1ebac8d8fa: Allow Nuance items to provide curtain panels, link to imported tasks, parse…
Summary

Ref T10537.

  • Let nuance items render custom curtain panels.
  • Add a custom panel linking to the imported task, if one exists.
  • Actually extract comments properly.
Test Plan

Unit tests, plus:

Screen Shot 2016-03-28 at 10.58.30 AM.png (252×737 px, 25 KB)

Screen Shot 2016-03-28 at 10.58.15 AM.png (324×406 px, 25 KB)

Diff Detail

Repository
rP Phabricator
Branch
nuance26
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 11320
Build 14081: Run Core Tests
Build 14080: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 37455.Mar 28 2016, 6:00 PM
epriestley retitled this revision from to Allow Nuance items to provide curtain panels, link to imported tasks, parse comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10537: Nuance Infrastructure.
Herald edited edge metadata. · View Herald TranscriptMar 28 2016, 6:00 PM
chad accepted this revision.Mar 28 2016, 6:09 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2016, 6:09 PM
Closed by commit rPda1ebac8d8fa: Allow Nuance items to provide curtain panels, link to imported tasks, parse… (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2016, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
nuance/
controller/
4 lines
github/
8 lines
__tests__/
1 line
repositoryevents/
3 lines
3 lines
item/
23 lines
8 lines

Diff 37455

View Options

src/applications/nuance/controller/NuanceItemViewController.php

Loading...
View Options

src/applications/nuance/github/NuanceGitHubRawEvent.php

Loading...
View Options

src/applications/nuance/github/__tests__/NuanceGitHubRawEventTestCase.php

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.pull.txt

Loading...
View Options

src/applications/nuance/github/__tests__/repositoryevents/IssueCommentEvent.created.txt

Loading...
View Options

src/applications/nuance/item/NuanceGitHubEventItemType.php

Loading...
View Options

src/applications/nuance/item/NuanceItemType.php

Loading...
Phabricator · Built by Phacility