Differential D15536

Archiving badge needs meaningful Badge timeline event title
ClosedPublic
Actions

Authored by lpriestley on Mar 28 2016, 5:34 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T10677: Update Badge transaction titles

Commits

rPa4270e5413b4: Archiving badge needs meaningful Badge timeline event title

Summary

Ref T10677, archiving/activating a badge should create non-generic timeline events.

Test Plan

Archive/activate badge, view badge timeline, see story corresponding to archiving/activating actions.

Diff Detail

Repository

rP Phabricator

Branch

badgesarchivetransaction

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 11318
Build 14078: Run Core Tests
Build 14077: arc lint + arc unit

Event Timeline

lpriestley updated this revision to Diff 37453.Mar 28 2016, 5:34 PM

lpriestley retitled this revision from to Archiving badge needs meaningful Badge timeline event title.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T10677: Update Badge transaction titles.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 28 2016, 5:34 PM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Mar 28 2016, 5:57 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 28 2016, 5:57 PM

Closed by commit rPa4270e5413b4: Archiving badge needs meaningful Badge timeline event title (authored by lpriestley, committed by lpriestley). · Explain WhyMar 28 2016, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

storage/

PhabricatorBadgesTransaction.php

12 lines

Diff 37453

View Options

src/applications/badges/storage/PhabricatorBadgesTransaction.php

Archiving badge needs meaningful Badge timeline event titleClosedPublicActions