Page MenuHomePhabricator
Differential D15466

Allow Remarkup tables to have leading space so they work correctly with quoting
ClosedPublic
Actions

Authored by epriestley on Mar 12 2016, 3:07 PM.
Tags
None
Referenced Files
F14919885: D15466.diff
Fri, Feb 14, 4:20 AM
F14918308: D15466.id37273.diff
Thu, Feb 13, 8:35 PM
Unknown Object (File)
Sun, Feb 9, 10:35 AM
Unknown Object (File)
Sun, Feb 9, 1:01 AM
Unknown Object (File)
Sun, Feb 9, 1:01 AM
Unknown Object (File)
Sun, Feb 9, 1:01 AM
Unknown Object (File)
Sat, Feb 8, 7:24 PM
Unknown Object (File)
Sat, Feb 8, 3:02 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10570: Default quote action breaks tables
Commits
rPHU89c7c2072813: (stable) Promote 2016 Week 11
rPHUf5f44f3a2c0b: Allow Remarkup tables to have leading space so they work correctly with quoting
Summary

Fixes T10570.

Test Plan

Screen Shot 2016-03-12 at 7.03.21 AM.png (655×788 px, 44 KB)

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37271.Mar 12 2016, 3:07 PM
epriestley retitled this revision from to Allow Remarkup tables to have leading space so they work correctly with quoting.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10570: Default quote action breaks tables.
Herald edited edge metadata. · View Herald TranscriptMar 12 2016, 3:07 PM
chad accepted this revision.Mar 12 2016, 3:56 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 12 2016, 3:56 PM
Closed by commit rPHUf5f44f3a2c0b: Allow Remarkup tables to have leading space so they work correctly with quoting (authored by epriestley, committed by epriestley). · Explain WhyMar 12 2016, 3:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
markup/
engine/
__tests__/
remarkup/
7 lines
7 lines
remarkup/
blockrule/
2 lines
4 lines

Diff 37273

View Options

src/markup/engine/__tests__/remarkup/simple-table-with-leading-space.txt

Loading...
View Options

src/markup/engine/__tests__/remarkup/table-with-leading-space.txt

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupSimpleTableBlockRule.php

Loading...
View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupTableBlockRule.php

Loading...
Phabricator · Built by Phacility