Page MenuHomePhabricator

When `arc` pushes to the staging area, tell Phabricator what we did

Authored by epriestley on Mar 7 2016, 3:15 PM.



Ref T10093. Right now, Phabricator kind of guesses that arc probably pushed stuff to the staging area.

This can cause confusing/misleading errors later, if it didn't actually push.

Instead, tell Phabricator that we pushed, so we can raise more tailored messages in the web UI (e.g., make "Land Revision" say "this wasn't pushed to the staging area" instead of "whoops, error!!~").

Test Plan

Ran arc diff a few times, then looked in the database for properties.

Screen Shot 2016-03-07 at 7.12.44 AM.png (545×1 px, 129 KB)

Diff Detail

rARC Arcanist
Lint Not Applicable
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When `arc` pushes to the staging area, tell Phabricator what we did.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2016, 3:21 PM
This revision was automatically updated to reflect the committed changes.