Page MenuHomePhabricator
Differential D15416

Convert every two-column application except Maniphest to curtain views
ClosedPublic
Actions

Authored by epriestley on Mar 6 2016, 6:10 PM.
Tags
None
Referenced Files
F14724279: D15416.id37164.diff
Sat, Jan 18, 1:10 AM
Unknown Object (File)
Fri, Jan 17, 8:51 PM
Unknown Object (File)
Fri, Jan 17, 8:30 AM
Unknown Object (File)
Sat, Dec 21, 1:03 PM
Unknown Object (File)
Dec 19 2024, 1:51 PM
Unknown Object (File)
Dec 19 2024, 11:02 AM
Unknown Object (File)
Dec 18 2024, 1:30 AM
Unknown Object (File)
Dec 18 2024, 1:30 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPfd9de5d6ecc8: Convert every two-column application except Maniphest to curtain views
Summary

Moves over everything except Maniphest, which has some special behavior.

Test Plan
  • Viewed a badge.
  • Viewed a calendar event.
  • Viewed a countdown.
  • Viewed a Fund initiative.
  • Viewed a Herald rule.
  • Viewed a macro.
  • Viewed an application.
  • Viewed an owners package.
  • Viewed a credential.
  • Viewed a Ponder question.
  • Viewed a poll.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37164.Mar 6 2016, 6:10 PM
epriestley retitled this revision from to Convert every two-column application except Maniphest to curtain views.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Mar 6 2016, 6:41 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2016, 6:41 PM
Closed by commit rPfd9de5d6ecc8: Convert every two-column application except Maniphest to curtain views (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2016, 6:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
controller/
54 lines
base/
controller/
10 lines
calendar/
controller/
41 lines
countdown/
controller/
40 lines
fund/
controller/
44 lines
herald/
controller/
49 lines
macro/
controller/
44 lines
meta/
controller/
50 lines
owners/
controller/
90 lines
passphrase/
controller/
51 lines
ponder/
controller/
43 lines
slowvote/
controller/
41 lines

Diff 37168

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/countdown/controller/PhabricatorCountdownViewController.php

Loading...
View Options

src/applications/fund/controller/FundInitiativeViewController.php

Loading...
View Options

src/applications/herald/controller/HeraldRuleViewController.php

Loading...
View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Loading...
View Options

src/applications/meta/controller/PhabricatorApplicationDetailViewController.php

Loading...
View Options

src/applications/owners/controller/PhabricatorOwnersDetailController.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialViewController.php

Loading...
View Options

src/applications/ponder/controller/PonderQuestionViewController.php

Loading...
View Options

src/applications/slowvote/controller/PhabricatorSlowvotePollController.php

Loading...
Phabricator · Built by Phacility