Clean up Macro view page
ClosedPublic
Actions

Authored by chad on Mar 5 2016, 8:30 PM.

Tags

None

Referenced Files

	F15179929: D15406.id37144.diff
	Wed, Feb 19, 5:12 PM

	Unknown Object (File)
	Wed, Feb 12, 1:00 AM

	Unknown Object (File)
	Wed, Feb 12, 12:47 AM

	Unknown Object (File)
	Wed, Feb 5, 6:52 AM

	Unknown Object (File)
	Fri, Jan 31, 5:35 AM

	Unknown Object (File)
	Fri, Jan 31, 5:26 AM

	Unknown Object (File)
	Thu, Jan 30, 9:04 AM

	Unknown Object (File)
	Thu, Jan 30, 1:13 AM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rP090252a89e2b: Clean up Macro view page

Summary

Sets a header icon, makes "Details" not show if empty, simplifies title.

Test Plan

Review a few Macro pages for changes with and without audio.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37142.Mar 5 2016, 8:30 PM

chad retitled this revision from to Clean up Macro view page.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 5 2016, 8:30 PM

epriestley accepted this revision.Mar 5 2016, 8:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 5 2016, 8:41 PM

Closed by commit rP090252a89e2b: Clean up Macro view page (authored by chad, committed by chad). · Explain WhyMar 5 2016, 8:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

controller/

PhabricatorMacroViewController.php

9 lines

Diff 37144

View Options

src/applications/macro/controller/PhabricatorMacroViewController.php

Clean up Macro view pageClosedPublicActions