Page MenuHomePhabricator
Differential D15382

Update Badges for PHUITwoColumnView
ClosedPublic
Actions

Authored by chad on Mar 2 2016, 6:55 PM.
Tags
None
Referenced Files
F13163126: D15382.diff
Mon, May 6, 5:54 PM
Unknown Object (File)
Sat, May 4, 10:09 PM
Unknown Object (File)
Wed, May 1, 1:03 AM
Unknown Object (File)
Tue, Apr 30, 5:43 AM
Unknown Object (File)
Sun, Apr 14, 1:12 AM
Unknown Object (File)
Fri, Apr 12, 9:28 AM
Unknown Object (File)
Fri, Apr 12, 9:28 AM
Unknown Object (File)
Thu, Apr 11, 10:51 AM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T10318: Make it easier to award badges
Commits
Restricted Diffusion Commit
rPb9a13e56e43e: Update Badges for PHUITwoColumnView
Summary

Updates the layout to two column, moves "Add Receipients" to dialog. Ref T10318

Test Plan

Give badges, revoke badges.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37090.Mar 2 2016, 6:55 PM
chad retitled this revision from to Update Badges for PHUITwoColumnView.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T10318: Make it easier to award badges.
Herald added a subscriber: Korvin. · View Herald TranscriptMar 2 2016, 6:55 PM
chad updated this object.Mar 2 2016, 6:57 PM
chad updated this revision to Diff 37091.Mar 2 2016, 7:06 PM
  • simpler code
epriestley accepted this revision.Mar 2 2016, 7:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2016, 7:16 PM
Closed by commit rPb9a13e56e43e: Update Badges for PHUITwoColumnView (authored by chad, committed by chad). · Explain WhyMar 2 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37092

View Options

resources/celerity/map.php

Loading...
View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesEditRecipientsController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesRemoveRecipientsController.php

Loading...
View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php

Loading...
View Options

src/applications/badges/view/PhabricatorBadgesRecipientsListView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-two-column-view.css

Loading...
Phabricator · Built by Phacility