Page MenuHomePhabricator

Slightly simplify the Harbormaster build log API
ClosedPublic

Authored by epriestley on Mar 1 2016, 3:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 6:50 AM
Unknown Object (File)
Fri, Apr 19, 4:16 PM
Unknown Object (File)
Wed, Apr 17, 3:16 PM
Unknown Object (File)
Thu, Apr 4, 10:08 PM
Unknown Object (File)
Mon, Apr 1, 10:11 PM
Unknown Object (File)
Mon, Apr 1, 10:11 PM
Unknown Object (File)
Mon, Apr 1, 10:09 PM
Unknown Object (File)
Mon, Apr 1, 8:54 PM
Subscribers
None

Details

Summary

Ref T5822. This prepares for inline compression and garbage collection of build logs.

This reduces the API surface area and removes a log from the "wait" step that would just log a message every 15 seconds. (If this is actually useful, I think we find a better way to communicate it.)

Test Plan

Ran a build, saw a log:

Screen Shot 2016-03-01 at 6.55.22 AM.png (619×693 px, 72 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Slightly simplify the Harbormaster build log API.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 3:14 PM
This revision was automatically updated to reflect the committed changes.