Page MenuHomePhabricator

Fix doubling of unbroken build steps in Build Plan view
ClosedPublic

Authored by epriestley on Mar 1 2016, 1:48 PM.

Details

Summary

Fixes T10479.

Test Plan

Viewed a valid build plan.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix doubling of unbroken build steps in Build Plan view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2016, 2:44 PM
This revision was automatically updated to reflect the committed changes.
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
116

Surely my missunderstanding but why isn't this $step_list->addItem()` deleted insead.
Or maybe it is the same ?

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
129

The second one does not execute for invalid steps.