Fix doubling of unbroken build steps in Build Plan view
ClosedPublic
Actions

Authored by epriestley on Mar 1 2016, 1:48 PM.

Details

Reviewers

hach-que
tycho.tatitscheff
chad

Maniphest Tasks

T10479: Harbormaster build steps are duplicated in the UI

Commits

Restricted Diffusion Commit
rP58cea0714bff: Fix doubling of unbroken build steps in Build Plan view

Summary

Fixes T10479.

Test Plan

Viewed a valid build plan.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37057.Mar 1 2016, 1:48 PM

epriestley retitled this revision from to Fix doubling of unbroken build steps in Build Plan view.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, hach-que, tycho.tatitscheff.

epriestley added a task: T10479: Harbormaster build steps are duplicated in the UI.

epriestley mentioned this in T10479: Harbormaster build steps are duplicated in the UI.Mar 1 2016, 2:17 PM

chad accepted this revision.Mar 1 2016, 2:44 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Mar 1 2016, 2:44 PM

Closed by commit rP58cea0714bff: Fix doubling of unbroken build steps in Build Plan view (authored by epriestley, committed by epriestley). · Explain WhyMar 1 2016, 2:51 PM

This revision was automatically updated to reflect the committed changes.

tycho.tatitscheff added inline comments.Mar 1 2016, 4:15 PM

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
116	Surely my missunderstanding but why isn't this $step_list->addItem()` deleted insead. Or maybe it is the same ?

epriestley added inline comments.Mar 1 2016, 7:34 PM

src/applications/harbormaster/controller/HarbormasterPlanViewController.php
129	The second one does not execute for invalid steps.

Revision Contents
Changeset List

Path

Size

src/

applications/

harbormaster/

controller/

HarbormasterPlanViewController.php

2 lines

Diff 37061

View Options

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

Fix doubling of unbroken build steps in Build Plan viewClosedPublicActions