Attempting to clean PHUIObjectBoxView up a little as well as finally being able to addClass on the sucker. I'm running into some issue with addTabs though, which on Files isn't firing.
Details
Details
- Reviewers
epriestley - Commits
- Restricted Diffusion Commit
rP12d852005962: Convert PHUIObjectBoxView to AphrontTagView
Bounce around tons of screens.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- object-box-tag (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 10732 Build 13199: Run Core Tests Build 13198: arc lint + arc unit
Event Timeline
Comment Actions
I think the issue is:
- getTagAttributes() is called first, and reads $this->tabMap, but it's currently empty.
- Later, getTagContent() is called, and builds and save $this->tabMap, but it's never read.
Easiest fix is probably:
- Implement willRender().
- Build tabMap there.
That may not be super easy since the construction of tabMap is a little complicated, but it doesn't look too unmanageable.