Page MenuHomePhabricator
Differential D15262

Don't autoname milestones, but do show the previous milestone name as a hint
ClosedPublic
Actions

Authored by epriestley on Feb 12 2016, 6:58 PM.
Tags
None
Referenced Files
F15433086: D15262.diff
Mon, Mar 24, 9:16 PM
F15394324: D15262.id36829.diff
Sat, Mar 15, 11:48 PM
F15394323: D15262.id36827.diff
Sat, Mar 15, 11:47 PM
F15394322: D15262.id.diff
Sat, Mar 15, 11:47 PM
F15394321: D15262.diff
Sat, Mar 15, 11:47 PM
F15387499: D15262.id36829.diff
Sat, Mar 15, 2:30 AM
F15385928: D15262.id36827.diff
Fri, Mar 14, 11:40 PM
F15385892: D15262.id36829.diff
Fri, Mar 14, 11:37 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10347: Have Milestone autocreate be more magical
Commits
Restricted Diffusion Commit
rPca908d7cc4a8: Don't autoname milestones, but do show the previous milestone name as a hint
Summary

Fixes T10347. In the long run maybe we'll try to guess this better, but for now get rid of the "Milestone X" hardcode and just show what the last one was called.

Test Plan
  • Created the first milestone for a project.
  • Created the nth milestone for a project.

Diff Detail

Repository
rP Phabricator
Branch
milestonemagic
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10669
Build 13104: Run Core Tests
Build 13103: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36827.Feb 12 2016, 6:58 PM
epriestley retitled this revision from to Don't autoname milestones, but do show the previous milestone name as a hint.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10347: Have Milestone autocreate be more magical.
chad accepted this revision.Feb 12 2016, 7:02 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 12 2016, 7:02 PM
Closed by commit rPca908d7cc4a8: Don't autoname milestones, but do show the previous milestone name as a hint (authored by epriestley, committed by epriestley). · Explain WhyFeb 12 2016, 7:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
project/
engine/
39 lines
query/
23 lines
transactions/
storage/
14 lines

Diff 36827

View Options

src/applications/project/engine/PhabricatorProjectEditEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectQuery.php

Loading...
View Options

src/applications/transactions/storage/PhabricatorEditEngineConfiguration.php

Loading...
Phabricator · Built by Phacility