Differential D15232

Fix two issues with unusual milestone workboard initialization orders
ClosedPublic
Actions

Authored by epriestley on Feb 10 2016, 1:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 18, 6:20 AM

	Unknown Object (File)
	Wed, Dec 18, 6:20 AM

	Unknown Object (File)
	Wed, Dec 18, 6:20 AM

	Unknown Object (File)
	Wed, Dec 18, 1:07 AM

	Unknown Object (File)
	Fri, Dec 13, 8:57 PM

	Unknown Object (File)
	Fri, Dec 13, 7:20 PM

	Unknown Object (File)
	Wed, Dec 11, 1:27 AM

	Unknown Object (File)
	Tue, Dec 3, 5:50 AM

Subscribers

None

Details

Reviewers

Maniphest Tasks

T10311: Using Milestone Column before Workboard creation causes exception
T10316: Call to a member function getSequence() on a non-object

Commits

Restricted Diffusion Commit
rP7bca452fad1b: Fix two issues with unusual milestone workboard initialization orders

Summary

Fixes T10316. Fixes T10311.

Test Plan

Create a project, create a milestone, go back to the parent, go to the workboard. Previously, fatal. Now, prompts you to create workboard.
Create a project, create a milestone, create the parent workboard, put a task in the milestone's column, go to the milestone workboard. Previously, fatal. Now, prompts you to create workboard.

Diff Detail

Repository

Branch

bfix1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10602
Build 13006: Run Core Tests
Build 13005: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36760.Feb 10 2016, 1:23 PM

epriestley retitled this revision from to Fix two issues with unusual milestone workboard initialization orders.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added tasks: T10316: Call to a member function getSequence() on a non-object, T10311: Using Milestone Column before Workboard creation causes exception.

epriestley mentioned this in T10316: Call to a member function getSequence() on a non-object.Feb 10 2016, 1:25 PM

chad accepted this revision.Feb 10 2016, 3:20 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Feb 10 2016, 3:20 PM

Closed by commit rP7bca452fad1b: Fix two issues with unusual milestone workboard initialization orders (authored by epriestley, committed by epriestley). · Explain WhyFeb 10 2016, 8:31 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T10348: "Undefined variable: default_phid" when open Workboard.Feb 12 2016, 6:34 PM

epriestley mentioned this in T10359: Exception when adding a milestone and a workboard to a subproject.Feb 15 2016, 1:16 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

project/

controller/

PhabricatorProjectBoardViewController.php

12 lines

engine/

PhabricatorBoardLayoutEngine.php

13 lines

Diff 36760

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Loading...