Normalize icon color on user/project lists.
ClosedPublic
Actions

Authored by chad on Feb 5 2016, 8:28 PM.

Details

Reviewers

epriestley

Commits

Restricted Diffusion Commit
rPe2668a5fd04b: Normalize icon color on user/project lists.

Summary

Minor, just fall back to the grey icon in all cases (too much color for me).

Test Plan

Review a Project and a Profile

Diff Detail

Repository

rP Phabricator

Branch

proj-list (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 10515
Build 12874: Run Core Tests
Build 12873: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36671.Feb 5 2016, 8:28 PM

chad retitled this revision from to Normalize icon color on user/project lists..

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 5 2016, 8:28 PM

epriestley accepted this revision.Feb 5 2016, 8:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Feb 5 2016, 8:29 PM

There's now no actual indication of the tag color of a project on the list view. Maybe bars?

I'm not sure it's helpful on these views. In most cases we show a subsection of all available meta-data. Like, we'll show the name, icon, and color, but not the image. On workboards this is great. In list views though I don't find the color very useful (I'm mostly just looking at the name).

That is, it's a little odd that I can query by color but can't actually see which results are which color:

Screen Shot 2016-02-05 at 12.32.43 PM.png (296×484 px, 27 KB)

I'm fine with getting rid of it but we should probably remove query-by-color and projects.colors if we do. I only added the config like two weeks ago so users probably aren't too attached to it yet.