Page MenuHomePhabricator

De-garbage the horrible garbage project section of the policy selection control
ClosedPublic

Authored by epriestley on Feb 4 2016, 8:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 1:41 AM
Unknown Object (File)
Fri, Mar 8, 10:50 PM
Unknown Object (File)
Feb 26 2024, 1:28 PM
Unknown Object (File)
Feb 13 2024, 1:41 AM
Unknown Object (File)
Jan 24 2024, 2:22 PM
Unknown Object (File)
Jan 22 2024, 6:56 PM
Unknown Object (File)
Jan 22 2024, 6:52 PM
Unknown Object (File)
Jan 22 2024, 2:34 PM
Subscribers
None
Tokens
"Love" token, awarded by Luke081515.2.

Details

Summary

Fixes T4136.

When listing projects in the "Visible To" selector control:

  • Instead of showing every project you are a member of, show only a few.
  • Add an option to choose something else which isn't in the menu.
  • If you've used the control before, show the stuff you've selected in the recent past.
  • If you haven't used the control before or haven't used it much, show the stuff you've picked and them some filler.
  • Don't offer milestones.
  • Also don't offer milestones in the custom policy UI.
Test Plan

Screen Shot 2016-02-04 at 12.18.02 PM.png (1×1 px, 239 KB)

Screen Shot 2016-02-04 at 12.18.14 PM.png (1×1 px, 201 KB)

  • Selected a project.
  • Used "find" to select a different project.
  • Saw reasonable defaults.
  • Saw favorites stick.
  • Tried to typeahead a milestone (nope).
  • Used "Custom Policy", tried to typeahead a milestone (nope).
  • Used "Custom Policy" in general.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to De-garbage the horrible garbage project section of the policy selection control.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

yay

This revision is now accepted and ready to land.Feb 4 2016, 9:03 PM
This revision was automatically updated to reflect the committed changes.