Page MenuHomePhabricator
Differential D15183

Improve some column behaviors for Milestone/Subproject columns
ClosedPublic
Actions

Authored by epriestley on Feb 4 2016, 3:58 PM.
Tags
None
Referenced Files
F14394905: D15183.diff
Sun, Dec 22, 2:39 AM
Unknown Object (File)
Wed, Dec 18, 3:32 AM
Unknown Object (File)
Wed, Dec 18, 3:20 AM
Unknown Object (File)
Fri, Dec 13, 8:31 PM
Unknown Object (File)
Sat, Dec 7, 3:50 PM
Unknown Object (File)
Thu, Dec 5, 6:25 PM
Unknown Object (File)
Fri, Nov 29, 8:25 AM
Unknown Object (File)
Mon, Nov 25, 12:30 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10010: Implement Subprojects
Commits
Restricted Diffusion Commit
rPc01f23adfb82: Improve some column behaviors for Milestone/Subproject columns
Summary

Ref T10010.

  • Don't allow milestones to be reordered.
  • Hide phantom subproject columns when reodrering.
  • Don't allow subproject/milestone columns to be renamed.
  • Force milestones to be ordered at the end, and in the correct order.
  • Add some missing crumbs.
Test Plan

Reordered columns, renamed columns, made a new column, viewed column details.

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10494
Build 12840: Run Core Tests
Build 12839: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36654.Feb 4 2016, 3:58 PM
epriestley retitled this revision from to Improve some column behaviors for Milestone/Subproject columns.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10010: Implement Subprojects.
chad accepted this revision.Feb 4 2016, 4:07 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 4 2016, 4:07 PM
Closed by commit rPc01f23adfb82: Improve some column behaviors for Milestone/Subproject columns (authored by epriestley, committed by epriestley). · Explain WhyFeb 4 2016, 4:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 36654

View Options

src/applications/project/controller/PhabricatorProjectBoardReorderController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnDetailController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectColumnEditController.php

Loading...
View Options

src/applications/project/engine/PhabricatorBoardLayoutEngine.php

Loading...
View Options

src/applications/project/storage/PhabricatorProjectColumn.php

Loading...
Phabricator · Built by Phacility