Page MenuHomePhabricator
Differential D15165

Use large text columns to store IP addresses
ClosedPublic
Actions

Authored by epriestley on Feb 2 2016, 6:09 PM.
Tags
None
Referenced Files
F13123105: D15165.diff
Tue, Apr 30, 8:22 AM
Unknown Object (File)
Mon, Apr 29, 2:52 AM
Unknown Object (File)
Tue, Apr 9, 3:13 AM
Unknown Object (File)
Mar 22 2024, 7:56 AM
Unknown Object (File)
Mar 9 2024, 7:13 PM
Unknown Object (File)
Mar 7 2024, 4:53 AM
Unknown Object (File)
Mar 7 2024, 4:53 AM
Unknown Object (File)
Mar 7 2024, 4:53 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10259: fetch log crashes when using IP v6 (http), fetch fails
Commits
Restricted Diffusion Commit
rP9d125b459ea8: Use large text columns to store IP addresses
Summary

Fixes T10259. There was no real reason to do this ip2long() stuff in the first place -- it's very slightly smaller, but won't work with ipv6 and the savings are miniscule.

Test Plan
  • Ran migration.
  • Viewed logs in web UI.
  • Pulled and pushed.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36614.Feb 2 2016, 6:09 PM
epriestley retitled this revision from to Use large text columns to store IP addresses.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10259: fetch log crashes when using IP v6 (http), fetch fails.
chad accepted this revision.Feb 2 2016, 6:10 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Feb 2 2016, 6:10 PM
Closed by commit rP9d125b459ea8: Use large text columns to store IP addresses (authored by epriestley, committed by epriestley). · Explain WhyFeb 2 2016, 6:13 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in T12215: Bad session URL in http://PHABRICATOR/people/logs/.Feb 6 2017, 12:34 PM

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
5 lines
39 lines
src/
aphront/
8 lines
applications/
config/
schema/
1 line
diffusion/
controller/
7 lines
engine/
11 lines
view/
9 lines
people/
view/
4 lines
repository/
storage/
2 lines
2 lines

Diff 36615

View Options

resources/sql/autopatches/20160202.ipv6.1.sql

Loading...
View Options

resources/sql/autopatches/20160202.ipv6.2.php

Loading...
View Options

src/aphront/AphrontRequest.php

Loading...
View Options

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Loading...
View Options

src/applications/diffusion/view/DiffusionPushLogListView.php

Loading...
View Options

src/applications/people/view/PhabricatorUserLogView.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPullEvent.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPushEvent.php

Loading...
Phabricator · Built by Phacility