Page MenuHomePhabricator

Apply phutil_utf8ize() to stderr output from VCS commands prior to logging
ClosedPublic

Authored by epriestley on Jan 31 2016, 12:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jun 18 2025, 10:01 PM
Unknown Object (File)
May 25 2025, 12:51 PM
Unknown Object (File)
May 25 2025, 6:57 AM
Unknown Object (File)
May 20 2025, 1:57 PM
Unknown Object (File)
May 10 2025, 1:32 AM
Unknown Object (File)
May 8 2025, 6:49 PM
Unknown Object (File)
May 6 2025, 6:31 AM
Unknown Object (File)
Apr 26 2025, 11:27 AM
Subscribers
None

Details

Summary

Ref T10228. Commands like git-http-backend can emit errors with raw bytes in the output. Sanitize these if present so we can log them in JSON format.

Test Plan

Edited this into production. >_> sneaky sneaky <_<

Diff Detail

Repository
rP Phabricator
Branch
utf8ize
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10406
Build 12709: Run Core Tests
Build 12708: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Apply phutil_utf8ize() to stderr output from VCS commands prior to logging.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 31 2016, 12:04 AM
This revision was automatically updated to reflect the committed changes.