Apply phutil_utf8ize() to stderr output from VCS commands prior to logging
ClosedPublic
Actions

Authored by epriestley on Jan 31 2016, 12:04 AM.

Details

Reviewers

chad

Maniphest Tasks

T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails

Commits

Restricted Diffusion Commit
rP482da7f5dfb3: (stable) Apply phutil_utf8ize() to stderr output from VCS commands prior to…
rPe5947e08d389: Apply phutil_utf8ize() to stderr output from VCS commands prior to logging

Summary

Ref T10228. Commands like git-http-backend can emit errors with raw bytes in the output. Sanitize these if present so we can log them in JSON format.

Test Plan

Edited this into production. >_> sneaky sneaky <_<

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36565.Jan 31 2016, 12:04 AM

epriestley retitled this revision from to Apply phutil_utf8ize() to stderr output from VCS commands prior to logging.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.

chad accepted this revision.Jan 31 2016, 12:04 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Jan 31 2016, 12:04 AM

Closed by commit rPe5947e08d389: Apply phutil_utf8ize() to stderr output from VCS commands prior to logging (authored by epriestley, committed by epriestley). · Explain WhyJan 31 2016, 12:46 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionServeController.php

5 lines

Diff 36567

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Apply phutil_utf8ize() to stderr output from VCS commands prior to loggingClosedPublicActions