Page MenuHomePhabricator
Differential D15128

Make hidden and locked configuration even more explicit
ClosedPublic
Actions

Authored by epriestley on Jan 28 2016, 3:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 16, 2:28 AM
Unknown Object (File)
Sat, Dec 14, 5:14 PM
Unknown Object (File)
Fri, Dec 6, 6:20 PM
Unknown Object (File)
Sat, Nov 23, 11:51 PM
Unknown Object (File)
Sat, Nov 23, 2:44 AM
Unknown Object (File)
Nov 7 2024, 1:01 AM
Unknown Object (File)
Nov 7 2024, 1:01 AM
Unknown Object (File)
Nov 7 2024, 1:01 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by Luke081515.2.

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPc00cd5c2a31e: Make hidden and locked configuration even more explicit
Summary

A user in IRC seemed very confused by this, and worked extremely hard to shoot themsevles in the foot by manually writing locked configuration to the database.

Try to explain why configuration is locked better.

Test Plan

Mostly reading.

Screen Shot 2016-01-28 at 7.27.24 AM.png (788×1 px, 138 KB)

Screen Shot 2016-01-28 at 7.27.18 AM.png (736×1 px, 122 KB)

Diff Detail

Repository
rP Phabricator
Branch
clock1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10365
Build 12644: Run Core Tests
Build 12643: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 36523.Jan 28 2016, 3:29 PM
epriestley retitled this revision from to Make hidden and locked configuration even more explicit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley updated this revision to Diff 36524.Jan 28 2016, 3:31 PM
  • Found one extra word.
epriestley updated this revision to Diff 36525.Jan 28 2016, 3:32 PM
  • Workflows are just get and set.
Luke081515.2 awarded a token.Jan 28 2016, 3:52 PM
chad accepted this revision.Jan 28 2016, 4:05 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 28 2016, 4:05 PM
Closed by commit rPc00cd5c2a31e: Make hidden and locked configuration even more explicit (authored by epriestley, committed by epriestley). · Explain WhyJan 28 2016, 4:18 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in Z1336: General Chat.Jan 28 2016, 7:18 PM

Revision Contents
Changeset List

PathSize
src/
applications/
config/
controller/
72 lines
management/
7 lines
docs/
user/
configuration/
101 lines

Diff 36525

View Options

src/applications/config/controller/PhabricatorConfigEditController.php

Loading...
View Options

src/applications/config/management/PhabricatorConfigManagementSetWorkflow.php

Loading...
View Options

src/docs/user/configuration/configuration_locked.diviner

Loading...
Phabricator · Built by Phacility