Page MenuHomePhabricator
Differential D15109

Add an edit link on hover for Project profile images
ClosedPublic
Actions

Authored by chad on Jan 24 2016, 8:16 PM.
Tags
None
Referenced Files
F15475685: D15109.id36480.diff
Sun, Apr 6, 9:35 PM
F15470994: D15109.id36483.diff
Sat, Apr 5, 2:52 AM
F15468694: D15109.diff
Fri, Apr 4, 4:31 AM
F15458203: D15109.id.diff
Sun, Mar 30, 9:38 PM
F15457771: D15109.id36480.diff
Sun, Mar 30, 6:45 PM
F15456198: D15109.id36481.diff
Sun, Mar 30, 7:47 AM
F15456002: D15109.id36482.diff
Sun, Mar 30, 6:21 AM
F15453481: D15109.diff
Sat, Mar 29, 12:08 PM
View All Files
Subscribers
Korvin

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP19f4e8631f00: Add an edit link on hover for Project profile images
Summary

Minor point of polish, but feels really nice. Hover over photo and edit a link to change the picture.

Test Plan

hover hover, clicky clicky

pasted_file (197×311 px, 21 KB)

Diff Detail

Repository
rP Phabricator
Branch
hover-edit-header (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10318
Build 12572: Run Core Tests
Build 12571: arc lint + arc unit

Event Timeline

chad updated this revision to Diff 36480.Jan 24 2016, 8:16 PM
chad retitled this revision from to Add an edit link on hover for Project profile images.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptJan 24 2016, 8:16 PM
chad edited the test plan for this revision. (Show Details)Jan 24 2016, 8:16 PM
chad updated this revision to Diff 36481.Jan 24 2016, 8:20 PM
  • Remove border shadow
epriestley accepted this revision.Jan 24 2016, 9:03 PM
epriestley edited edge metadata.

Maybe only add this if the user has permission to edit it? Not sure.

This revision is now accepted and ready to land.Jan 24 2016, 9:03 PM
chad updated this revision to Diff 36482.Jan 24 2016, 9:19 PM
chad edited edge metadata.
  • Add edit check
Closed by commit rP19f4e8631f00: Add an edit link on hover for Project profile images (authored by chad, committed by chad). · Explain WhyJan 24 2016, 9:20 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
project/
controller/
3 lines
view/
phui/
43 lines
webroot/
rsrc/
css/
phui/
25 lines

Diff 36480

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectProfileController.php

Loading...
View Options

src/view/phui/PHUIHeaderView.php

Loading...
View Options

webroot/rsrc/css/phui/phui-header-view.css

Loading...
Phabricator · Built by Phacility