Page MenuHomePhabricator

Use "tag" more consistenty when referring to associating a project with an object
ClosedPublic

Authored by epriestley on Jan 24 2016, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 6:17 AM
Unknown Object (File)
Wed, Dec 18, 1:11 AM
Unknown Object (File)
Tue, Dec 17, 2:36 AM
Unknown Object (File)
Sun, Dec 15, 5:52 PM
Unknown Object (File)
Fri, Dec 13, 2:42 AM
Unknown Object (File)
Sat, Dec 7, 9:19 PM
Unknown Object (File)
Sat, Dec 7, 3:06 AM
Unknown Object (File)
Thu, Dec 5, 8:22 PM
Subscribers
None

Details

Summary

Ref T10144. This isn't comprehensive, but we can give it a try and see how it feels?

  • EditEngine forms now say "Tags" instead of "Projects".
  • Modern SearchEngine forms now say "Tags" instead of "Projects".
  • For clarity, replaced as much "in project" language as I could find with "tagged with project" language.
Test Plan

reading / grepping + used "not tagged with any project" token

Diff Detail

Repository
rP Phabricator
Branch
uicon5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10312
Build 12565: Run Core Tests
Build 12564: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Use "tag" more consistenty when referring to associating a project with an object.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

(Not committed to going SO EXTREME if this feels a little too far.)

I could go either way, I don't think there is A TON of confusion, but I think this helps new people more? maybe? s/query/filter is the other language change along this vein as well.

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 24 2016, 5:51 PM

Yeah -- I think "query" is probably OK for technical users but imagine "filter" might be much clearer for less technical users. I think that one's a little tricker to swap out, though. I don't immediately recall specific confusion from users about it (do you, offhand?) but am up for swapping it if we run into some or you just want to.

(I do think T10144 and all the junk I merged into it may represent a moderate amount of confusion about how projects and policies interact, although I'm not sure how many actual users this really affects. T9164 sounded like every user on an entire install was utterly bewildered by the behavior, but that isn't consistent with what we've seen elsewhere, so I'm not sure how large this effect really is. I think users who already have an accurate model of how projects work will probably take 3 seconds to adjust to this change, though, so the maximum badness is probably low.)

This revision was automatically updated to reflect the committed changes.

Yeah Query/Filter is more of "it sounds simpler and it's what other software uses". I don't think it's confusing, just more approachable.