Page MenuHomePhabricator

First cut of new Project Home
ClosedPublic

Authored by chad on Jan 23 2016, 9:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 1:10 AM
Unknown Object (File)
Tue, Dec 17, 10:29 AM
Unknown Object (File)
Mon, Dec 9, 10:56 AM
Unknown Object (File)
Fri, Dec 6, 5:05 PM
Unknown Object (File)
Wed, Dec 4, 3:26 AM
Unknown Object (File)
Mon, Nov 25, 7:06 AM
Unknown Object (File)
Mon, Nov 25, 2:42 AM
Unknown Object (File)
Thu, Nov 21, 1:53 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rPb381265d926a: First cut of new Project Home
Summary

First pass at a new Project Home page. This is starting to sprawl, so punting this up now before it gets too large.

  • Project homes now have "large header"
  • Custom Fields / Descriptions are in the main column
  • Feed is simpler visually
  • new "Background" option for PHUIObjectBoxView
  • move header buttons globally to "Grey" instead of "Simple"
  • New color and hover states for "Grey"
  • Transitions on Buttons haha
  • Edit Icon on Nav is now under "Manage" panel
  • New "Manage" Panel

TODO:

  • More testing of bad cases of Custom Fields
  • Members Page in flux, needs design
  • Um still not sure how to make Custom Field not show UI
Test Plan

Lots of random Project page visits. Save project, watch project, edit project, etc.

pasted_file (2×2 px, 514 KB)

Diff Detail

Repository
rP Phabricator
Branch
project-home (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10293
Build 12533: Run Core Tests
Build 12532: arc lint + arc unit

Event Timeline

chad retitled this revision from to First cut of new Project Home.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.

Cool, looks good. Minor stuff:

  • Loss of headers in description blocks is a little confusing if remarkup fields are present, compare "Description + Personnel" to no headers:

Screen Shot 2016-01-23 at 1.44.59 PM.png (1×2 px, 407 KB)

Screen Shot 2016-01-23 at 1.45.08 PM.png (1×2 px, 383 KB)

  • I think this is from earlier, but if you make the page short (or add lots of items) they become visible underneath "collapse". Without the spacer that this change removes, it is probably impossible to click the last item if the menu content is longer than the page content and window, because I expect it will be completely hidden by "Collapse". Here's a screenshot:

Screen Shot 2016-01-23 at 1.48.13 PM.png (588×620 px, 49 KB)

  • Background grey on members/watchers feels maybe a touch dark? Not sure. Buttons look a bit weird at first glance.
  • "Watch Project" feels kind of floaty/random? Not necessarily bad, but I did sort of like it right next to feed since it helped imply what watching does. Watching may be more obvious now that there's no subscribe, though.
  • It is now impossible to flag projects from the UI. I'm fine with dropping that, but we should probably un-implement FlaggableInterface if we do.

This is all fluff, only actual issue is the bad merge (I think?) on the "adjust defaults" code in PhabricatorProfilePanelEngine.php.

src/applications/project/controller/PhabricatorProjectManageController.php
131–134

(We can just drop this if you want, I just left it because I wasn't directly replacing it with an analog but I'm not attached to it whatsoever.)

src/applications/project/controller/PhabricatorProjectProfileController.php
63–64

This is never actually used, I think?

src/applications/search/engine/PhabricatorProfilePanelEngine.php
920

I think this section got merged badly and partially reverts D15092.

This revision now requires changes to proceed.Jan 23 2016, 9:59 PM
chad edited edge metadata.
chad marked 2 inline comments as done.
  • Fix bad merge
  • Float Watch Button better
  • Add back section titles
  • Fix collapse icon
  • Add 200px profile images
  • Remove unused header
This revision is now accepted and ready to land.Jan 24 2016, 12:10 AM

imma need your help on that if you have 5 minutes.

Yeah, I can fix that and take a crack at the empty properties thing.

Members is still jank, but I'll dig into that tonight.

This revision was automatically updated to reflect the committed changes.

I can't repro that overflow thing, any trick to it?

Screen Shot 2016-01-23 at 5.06.40 PM.png (346×1 px, 69 KB)

Overflow thing? Where my screenshot cut off? That's just where I screencapped it.

Oh, hahaha. I thought the "...tardestroyer" was some issue with the animation or something.

No, hehe. I just need help getting the description box to not show if nothing's set.