Page MenuHomePhabricator

Move member/watch actions to "Members/Watchers" page
ClosedPublic

Authored by epriestley on Jan 20 2016, 12:31 AM.
Tags
None
Referenced Files
F15337085: D15059.id36378.diff
Sun, Mar 9, 4:00 AM
F15335217: D15059.id36368.diff
Sat, Mar 8, 2:39 PM
Unknown Object (File)
Mon, Mar 3, 3:11 AM
Unknown Object (File)
Tue, Feb 18, 6:34 PM
Unknown Object (File)
Sun, Feb 16, 11:09 PM
Unknown Object (File)
Fri, Feb 14, 2:17 AM
Unknown Object (File)
Thu, Feb 13, 8:37 PM
Unknown Object (File)
Sun, Feb 9, 12:31 AM
Subscribers
None

Details

Summary

Ref T10054. This tries to make the members page a bit more consistent and provide hints to users about subproject/milestone membership rules. In particular:

  • You now join, leave, watch, unwatch, add and remove members, and lock and unlock membership from the members screen.
  • We now explain the membership rule for the project on this screen. There are currently four rules:
    • Normal Project: Join/leave normally.
    • Parent Project: Uses subprojects to determine members.
    • Milestone: Uses parent project to determine members.
    • Locked: Membership is locked.
    • (Future) Imported from LDAP/other external sources: Membership is determined by something else.
Test Plan

Screen Shot 2016-01-19 at 4.26.29 PM.png (1×1 px, 165 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move member/watch actions to "Members/Watchers" page.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I plan to make these additional related changes, but they didn't make sense in this pass:

  • Convert the members/watchers to the sleek new layout from the mocks.
  • When members are members via a subproject, show which subproject(s).
  • Put members/watchers 2-up on desktop.
  • Allow watchers to be removed by users who can edit the project.
  • Allow any user to watch a project.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 20 2016, 1:58 AM
This revision was automatically updated to reflect the committed changes.