Page MenuHomePhabricator
Differential D15029

Add a basic remarkup typeahead for users and projects
ClosedPublic
Actions

Authored by epriestley on Jan 15 2016, 1:22 PM.
Tags
None
Referenced Files
F14055680: D15029.diff
Sat, Nov 16, 2:40 PM
F14042844: D15029.diff
Tue, Nov 12, 6:35 AM
F14027428: D15029.diff
Fri, Nov 8, 7:09 AM
F14015434: D15029.id36292.diff
Sun, Nov 3, 6:47 PM
F13984021: D15029.id36293.diff
Sun, Oct 20, 10:26 AM
F13984012: D15029.id36294.diff
Sun, Oct 20, 10:23 AM
F13967731: D15029.id36292.diff
Oct 16 2024, 3:33 PM
F13961891: D15029.id36289.diff
Oct 15 2024, 6:53 AM
View All Files
Subscribers
None
Tokens
"Like" token, awarded by joshuaspence."Mountain of Wealth" token, awarded by avivey."Yellow Medal" token, awarded by chad.

Details

Reviewers
chad
Maniphest Tasks
T3725: Using keyword @ to address users does not autocomplete names
Commits
Restricted Diffusion Commit
rP5d6dd7df7d7a: Add a basic remarkup typeahead for users and projects
Summary

Ref T3725. This probably has 900,000 bugs. This will need updates for subprojects/milestones.

Test Plan
  • Tested very gently in Safari, Firefox and Chrome.
  • Reasonable inputs appear to work.
  • Clicking, escape, tab, return, arrow keys work OK?

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36289.Jan 15 2016, 1:22 PM
epriestley retitled this revision from to Add a basic remarkup typeahead for users and projects.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T3725: Using keyword @ to address users does not autocomplete names.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 1:22 PM
epriestley added a comment.Jan 15 2016, 1:23 PM

Screen Shot 2016-01-15 at 5.18.24 AM.png (222×476 px, 15 KB)

Screen Shot 2016-01-15 at 5.18.27 AM.png (238×512 px, 19 KB)

Screen Shot 2016-01-15 at 5.18.29 AM.png (223×414 px, 12 KB)

Screen Shot 2016-01-15 at 5.18.34 AM.png (237×455 px, 22 KB)

epriestley updated this revision to Diff 36290.Jan 15 2016, 1:25 PM
epriestley edited edge metadata.
  • Minor style fix.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 1:25 PM
epriestley updated this revision to Diff 36291.Jan 15 2016, 2:44 PM
epriestley edited edge metadata.
  • Deactivate when the user types @d, then clicks outside the text area.
  • Deactivate without autocompleting on Shift + Tab.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:44 PM
epriestley updated this revision to Diff 36292.Jan 15 2016, 2:48 PM
epriestley edited edge metadata.
  • If the user types "tab" or "return" to autocomplete but there are no matches, eat it without deactivating.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:48 PM
epriestley updated this revision to Diff 36293.Jan 15 2016, 2:55 PM
epriestley edited edge metadata.
  • Move configuration to PHP.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 2:55 PM
epriestley updated this revision to Diff 36294.Jan 15 2016, 3:06 PM
epriestley edited edge metadata.
  • When a user types "@", try to guess whether they're trying to type a username or not by examining the text prior to the "@".
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 3:06 PM
epriestley updated this revision to Diff 36295.Jan 15 2016, 3:17 PM
epriestley edited edge metadata.
  • When the user types "@whatever<comma, space or colon>", drop the suffix when querying and retain it when autocompleting so we don't eat spaces/colons/etc.
Herald edited edge metadata. · View Herald TranscriptJan 15 2016, 3:17 PM
chad accepted this revision.Jan 15 2016, 4:36 PM
chad edited edge metadata.

whatcouldgowrong4

This revision is now accepted and ready to land.Jan 15 2016, 4:36 PM
chad added a comment.Jan 15 2016, 4:36 PM

(i think this is super awesome btw)

chad awarded a token.Jan 15 2016, 4:36 PM
epriestley added a comment.Jan 15 2016, 4:37 PM

I think I'm going to cut stable today and then land all this whack junk (this + profile menu).

avivey awarded a token.Jan 15 2016, 4:44 PM
Closed by commit rP5d6dd7df7d7a: Add a basic remarkup typeahead for users and projects (authored by epriestley, committed by epriestley). · Explain WhyJan 15 2016, 5:11 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence awarded a token.Jan 17 2016, 2:32 AM
joshuaspence mentioned this in T10163: Remarkup Autocomplete Errata.Jan 17 2016, 2:39 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
71 lines
src/
applications/
people/
typeahead/
7 lines
project/
typeahead/
7 lines
typeahead/
storage/
11 lines
view/
form/
control/
17 lines
webroot/
rsrc/
css/
core/
49 lines
4 lines
js/
core/
3 lines
10 lines
phuix/
504 lines

Diff 36300

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/people/typeahead/PhabricatorPeopleDatasource.php

Loading...
View Options

src/applications/project/typeahead/PhabricatorProjectDatasource.php

Loading...
View Options

src/applications/typeahead/storage/PhabricatorTypeaheadResult.php

Loading...
View Options

src/view/form/control/PhabricatorRemarkupControl.php

Loading...
View Options

webroot/rsrc/css/core/remarkup.css

Loading...
View Options

webroot/rsrc/css/core/z-index.css

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
View Options

webroot/rsrc/js/core/behavior-phabricator-remarkup-assist.js

Loading...
View Options

webroot/rsrc/js/phuix/PHUIXAutocomplete.js

Loading...
Phabricator · Built by Phacility