Page MenuHomePhabricator

Rough initial cut of profile new profile menu
ClosedPublic

Authored by epriestley on Jan 14 2016, 1:04 AM.
Tags
None
Referenced Files
F14352283: D15016.id36268.diff
Thu, Dec 19, 1:28 PM
F14352282: D15016.id.diff
Thu, Dec 19, 1:28 PM
Unknown Object (File)
Fri, Dec 13, 9:39 PM
Unknown Object (File)
Thu, Dec 5, 11:16 AM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 11:20 PM
Unknown Object (File)
Mon, Dec 2, 12:50 PM
Unknown Object (File)
Sun, Dec 1, 12:33 AM
Subscribers
None

Details

Summary

Ref T10054. I haven't done any of the big-picture layout stuff yet, but this should get look-and-feel somewhere in the ballpark of reasonablness, I think.

Major missing stuff:

  • No "collapse" state or action yet.
  • Menu is not full-height (requires changes to the rendering pipeline).
Test Plan

Screen Shot 2016-01-13 at 4.59.39 PM.png (1×1 px, 206 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Rough initial cut of profile new profile menu.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.

I'll hold this until full-height is also built/approved since the partial-height is super weird. I probably got colors/layouts not-quite-right, feel free to counterdiff on anything that looks a bit off.

chad edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2016, 9:06 PM
This revision was automatically updated to reflect the committed changes.