Page MenuHomePhabricator

Begin modularizing profile panel/link construction
ClosedPublic

Authored by epriestley on Jan 12 2016, 7:50 PM.
Tags
None
Referenced Files
F14050219: D15007.diff
Thu, Nov 14, 5:26 PM
F14038607: D15007.diff
Mon, Nov 11, 12:46 AM
F14022881: D15007.diff
Wed, Nov 6, 8:44 PM
F14008360: D15007.id36251.diff
Tue, Oct 29, 8:00 PM
F13999614: D15007.diff
Thu, Oct 24, 4:00 PM
F13991396: D15007.id.diff
Tue, Oct 22, 10:35 AM
F13955111: D15007.id36256.diff
Oct 14 2024, 12:14 AM
Unknown Object (File)
Oct 5 2024, 9:00 PM
Subscribers
None

Details

Summary

Ref T10054. This has no product impact, but prepares us for customizable side nav on "profiles" (today, projects; probably users some day; and maybe other stuff down the road).

Test Plan

Clicked all links on a profile, everything was exactly the same as before.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Begin modularizing profile panel/link construction.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.

I suspect we can run home off of this as well? Pretty much most of the features will duplicate (re-order, etc) and I'd still like a minimal view personally for home.

This revision is now accepted and ready to land.Jan 12 2016, 9:31 PM

Yeah, I think that should work. It's going to take a little massaging since there's no proper object to pull by PHID, but I can namespace them or something.

(By "minimal", you just mean you want to be able to collapse the menu? You can already remove every application if you want, right?)

This revision was automatically updated to reflect the committed changes.