Page MenuHomePhabricator

Remove "username@phabricator.mycompany.com" creating a Conpherence
ClosedPublic

Authored by epriestley on Jan 11 2016, 6:31 PM.
Tags
None
Referenced Files
F13291508: D14997.id.diff
Wed, Jun 5, 12:02 AM
F13291507: D14997.diff
Wed, Jun 5, 12:02 AM
F13284931: D14997.id36229.diff
Mon, Jun 3, 11:11 AM
F13256073: D14997.diff
Sat, May 25, 9:26 AM
F13240831: D14997.id.diff
Wed, May 22, 4:57 PM
F13205718: D14997.diff
Wed, May 15, 2:18 AM
F13189900: D14997.diff
Sat, May 11, 6:32 AM
F13180688: D14997.id36229.diff
Thu, May 9, 2:27 AM
Subscribers
None

Details

Summary

Ref T10121. This doesn't work at all at HEAD, and even when it did it was mostly just confusing to installs with unexpected setups where Phabricator is receiving mail at @mycompany.com and this is colliding with real addresses.

It might make sense to restore it some day after the next Conphernece update, but just strip it out for now. Since it doesn't work anyway, I'm pretty confident no one is using it.

Test Plan
  • Before patch: send mail to dog@local.phacility.com, got a policy error from Conpherece.
  • After patch: sent mail to dog@local.phacility.com, got a correct "no routable recipients" error.

Diff Detail

Repository
rP Phabricator
Branch
nouroom
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 10063
Build 12181: Run Core Tests
Build 12180: arc lint + arc unit

Event Timeline

epriestley retitled this revision from to Remove "username@phabricator.mycompany.com" creating a Conpherence.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 6:32 PM
This revision was automatically updated to reflect the committed changes.