Page MenuHomePhabricator
Differential D14992

Improve behavior of "owner" transaction in "maniphest.edit" endpoint
ClosedPublic
Actions

Authored by epriestley on Jan 11 2016, 11:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 2:06 AM
Unknown Object (File)
Sat, Dec 7, 1:54 PM
Unknown Object (File)
Fri, Dec 6, 9:19 AM
Unknown Object (File)
Nov 11 2024, 6:43 AM
Unknown Object (File)
Nov 4 2024, 7:41 AM
Unknown Object (File)
Oct 20 2024, 2:31 AM
Unknown Object (File)
Oct 18 2024, 9:09 PM
Unknown Object (File)
Oct 18 2024, 9:06 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T10117: Exception when trying to unassign owner via conduit maniphest.edit endpoint
Commits
Restricted Diffusion Commit
rPadd8333b98cb: Improve behavior of "owner" transaction in "maniphest.edit" endpoint
Summary

Fixes T10117.

  • I accidentally broke setting null to unassign tasks at some point when I added richer validation.
  • Raise a better error if the user passes junk.
Test Plan
  • Unassigned a task via API and web UI.
  • Reassigned a task via API and web UI.
  • Tried to do an invalid assign via API, got a sensible error.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 36213.Jan 11 2016, 11:29 AM
epriestley retitled this revision from to Improve behavior of "owner" transaction in "maniphest.edit" endpoint.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T10117: Exception when trying to unassign owner via conduit maniphest.edit endpoint.
chad accepted this revision.Jan 11 2016, 5:18 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Jan 11 2016, 5:18 PM
Closed by commit rPadd8333b98cb: Improve behavior of "owner" transaction in "maniphest.edit" endpoint (authored by epriestley, committed by epriestley). · Explain WhyJan 11 2016, 5:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
conduit/
parametertype/
47 lines
maniphest/
editor/
27 lines
transactions/
editengine/
3 lines
editfield/
1 line
6 lines

Diff 36224

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conduit/parametertype/ConduitUserParameterType.php

Loading...
View Options

src/applications/maniphest/editor/ManiphestTransactionEditor.php

Loading...
View Options

src/applications/transactions/editengine/PhabricatorEditEngine.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorPHIDListEditField.php

Loading...
View Options

src/applications/transactions/editfield/PhabricatorUsersEditField.php

Loading...
Phabricator · Built by Phacility