Page MenuHomePhabricator
Differential D14917

fix broken link for project creating button
ClosedPublic
Actions

Authored by zhuangya on Dec 31 2015, 7:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 7:03 PM
Unknown Object (File)
Mar 5 2024, 5:19 PM
Unknown Object (File)
Mar 5 2024, 5:19 PM
Unknown Object (File)
Mar 5 2024, 5:19 PM
Unknown Object (File)
Feb 29 2024, 12:34 PM
Unknown Object (File)
Feb 29 2024, 11:31 AM
Unknown Object (File)
Feb 23 2024, 11:24 AM
Unknown Object (File)
Feb 23 2024, 11:24 AM
View All Files
Subscribers
epriestley
joshuaspence

Details

Reviewers
joshuaspence
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T10074: wrong href for green "create project" button
Commits
Restricted Diffusion Commit
rP84a570a61b8e: fix broken link for project creating button
Summary

fix T10074

Test Plan

click the "create project" button

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

zhuangya updated this revision to Diff 36047.Dec 31 2015, 7:40 AM
zhuangya retitled this revision from to fix broken link for project creating button.
zhuangya updated this object.
zhuangya edited the test plan for this revision. (Show Details)
zhuangya added a reviewer: btrahan.
zhuangya set the repository for this revision to rP Phabricator.
zhuangya added a task: T10074: wrong href for green "create project" button.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptDec 31 2015, 7:40 AM
Herald added a subscriber: epriestley. · View Herald Transcript
joshuaspence accepted this revision.Dec 31 2015, 10:35 AM
joshuaspence added a reviewer: joshuaspence.
joshuaspence added a subscriber: joshuaspence.

Seems legit

joshuaspence removed a reviewer: btrahan.Dec 31 2015, 10:35 AM
epriestley accepted this revision.Dec 31 2015, 1:56 PM
epriestley added a reviewer: epriestley.

This should just be /edit/ with no extra stuff, but I'll tweak that in the pull. Thanks for the fix!

This revision is now accepted and ready to land.Dec 31 2015, 1:56 PM
epriestley added a comment.Dec 31 2015, 1:58 PM

Oh, this is also the wrong place -- the correct link is in PhabricatorProjectSearchEngine.php. But this one is also buggy. I'll fix them both up.

Closed by commit rP84a570a61b8e: fix broken link for project creating button (authored by epriestley, committed by epriestley). · Explain WhyDec 31 2015, 1:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
9 lines
project/
query/
2 lines

Diff 36048

View Options

src/applications/diffusion/controller/DiffusionCommitEditController.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
Phabricator · Built by Phacility