Differential D14882

Separate "internal" and "external" links on profiles
AbandonedPublic
Actions

Authored by epriestley on Dec 24 2015, 9:23 PM.

Details

Reviewers

chad

Summary

This is just an exploratory diff in the general direction of T10054. Feels slightly better/clearer to me?

If we do pursue this, I'd plan to:

Just leave user profiles like this indefinitely, until we're touching them again for some reason.
Probably just let users put whatever they want on Project profiles.

Test Plan

Screen Shot 2015-12-24 at 1.19.54 PM.png (1×2 px, 194 KB)

Screen Shot 2015-12-24 at 1.19.43 PM.png (1×1 px, 148 KB)

Diff Detail

Repository

rP Phabricator

Branch

projicon1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 9792
Build 11775: Run Core Tests
Build 11774: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35973.Dec 24 2015, 9:23 PM

epriestley retitled this revision from to Separate "internal" and "external" links on profiles.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

Herald edited edge metadata. · View Herald TranscriptDec 24 2015, 9:23 PM

I two other directions to explore in Photoshop land, not sure when I can find the time to sketch them out. Let me get a napkin.

(Basically I want to ditch icon-nav outright with tabs, either on the left or horizontal as a bar.

Awesome, looking forward to it!

(And definitely no rush if you want to think it over for a while or try different things, T10054 was just me braindumping after thinking about some of this stuff for the last few days while doing infrastructure work.)