Page MenuHomePhabricator
Differential D14880

Keep hovercards on screen a little harder
ClosedPublic
Actions

Authored by epriestley on Dec 24 2015, 8:34 PM.
Tags
None
Referenced Files
F15531865: D14880.diff
Wed, Apr 23, 1:29 PM
F15527328: D14880.diff
Tue, Apr 22, 2:50 AM
F15517954: D14880.diff
Sat, Apr 19, 9:48 AM
F15507915: D14880.diff
Wed, Apr 16, 12:08 AM
F15503717: D14880.id35969.diff
Mon, Apr 14, 12:27 PM
F15486155: D14880.id35969.diff
Thu, Apr 10, 5:21 AM
F15486078: D14880.id35970.diff
Thu, Apr 10, 4:49 AM
F15484892: D14880.diff
Wed, Apr 9, 8:49 PM
View All Files
Subscribers
None

Details

Reviewers
chad
Maniphest Tasks
T8980: Make hovecards activate for standard handle lists
Commits
Restricted Diffusion Commit
rP8025bc6432e2: Keep hovercards on screen a little harder
Summary

Ref T8980. This calculation was not quite right and you could sneak one off screen if you tried carefully.

Test Plan

Couldn't sneak one off screen anymore.

Diff Detail

Repository
rP Phabricator
Branch
hover4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9788
Build 11768: Run Core Tests
Build 11767: arc lint + arc unit

Event Timeline

epriestley updated this revision to Diff 35969.Dec 24 2015, 8:34 PM
epriestley retitled this revision from to Keep hovercards on screen a little harder.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
epriestley added a task: T8980: Make hovecards activate for standard handle lists.
chad accepted this revision.Dec 24 2015, 8:35 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 24 2015, 8:35 PM
Closed by commit rP8025bc6432e2: Keep hovercards on screen a little harder (authored by epriestley, committed by epriestley). · Explain WhyDec 24 2015, 8:38 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
20 lines
src/
applications/
maniphest/
controller/
5 lines
webroot/
rsrc/
js/
core/
2 lines

Diff 35969

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...
View Options

webroot/rsrc/js/core/Hovercard.js

Loading...
Phabricator · Built by Phacility