Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine
ClosedPublic

Authored by epriestley on Dec 21 2015, 3:23 PM.
Tags
None
Referenced Files
F18085514: D14837.id.diff
Tue, Aug 5, 7:16 PM
F18053907: D14837.id.diff
Mon, Aug 4, 5:47 AM
F17946266: D14837.id.diff
Thu, Jul 31, 2:03 PM
F17928158: D14837.diff
Wed, Jul 30, 3:50 PM
F17761351: D14837.id35892.diff
Tue, Jul 22, 8:38 PM
F17758115: D14837.id.diff
Tue, Jul 22, 4:51 PM
F17757315: D14837.id35865.diff
Tue, Jul 22, 4:01 PM
F17738291: D14837.diff
Sun, Jul 20, 11:21 PM
Subscribers
None

Details

Summary

Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.