Page MenuHomePhabricator

Modularize transaction/comment indexing in the FulltextEngine
ClosedPublic

Authored by epriestley on Dec 21 2015, 3:23 PM.
Tags
None
Referenced Files
F18737814: D14837.id.diff
Wed, Oct 1, 12:45 PM
F18730636: D14837.diff
Tue, Sep 30, 1:24 PM
F18663362: D14837.id.diff
Tue, Sep 23, 10:35 PM
F18645651: D14837.diff
Fri, Sep 19, 8:20 AM
F18636185: D14837.id35892.diff
Wed, Sep 17, 3:42 AM
F18610138: D14837.id35892.diff
Sun, Sep 14, 4:21 AM
F18604276: D14837.id35865.diff
Sat, Sep 13, 6:24 PM
F18581559: D14837.diff
Thu, Sep 11, 6:26 AM
Subscribers
None

Details

Summary

Ref T9979. This is currently hard-coded but can be done in a generic way.

This has one minor behavioral changes: answer text is no longer included in the question text index in Ponder. I'm not planning to accommodate that for now since I don't want to dig this hole any deeper than I already have. This behavior should be different anyway (e.g., index the answer, then show the question in the results or something).

Test Plan
  • Put a unique word in a Maniphest comment.
  • Searched for the word.
  • Found the task.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Modularize transaction/comment indexing in the FulltextEngine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad edited edge metadata.
This revision is now accepted and ready to land.Dec 21 2015, 3:54 PM
This revision was automatically updated to reflect the committed changes.