Page MenuHomePhabricator
Differential D14830

Add a pirate translation
ClosedPublic
Actions

Authored by chad on Dec 20 2015, 3:16 AM.
Tags
None
Subscribers
hach-que
joshuaspence
Korvin
Tokens
"Mountain of Wealth" token, awarded by hach-que."Doubloon" token, awarded by joshuaspence."Doubloon" token, awarded by epriestley.

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP006321cce76b: Add a pirate translation
Summary

Basic Pirate, mostly Maniphest

Test Plan

Play lots with Maniphest

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 35857.Dec 20 2015, 3:16 AM
chad retitled this revision from to Add a pirate translation.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added a subscriber: Korvin. · View Herald TranscriptDec 20 2015, 3:16 AM
epriestley accepted this revision.Dec 20 2015, 2:52 PM
epriestley edited edge metadata.

Haha, these are great.

src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
30

tails -> tales

This revision is now accepted and ready to land.Dec 20 2015, 2:52 PM
epriestley awarded a token.Dec 20 2015, 2:52 PM
Closed by commit rP006321cce76b: Add a pirate translation (authored by chad, committed by chad). · Explain WhyDec 20 2015, 3:03 PM
This revision was automatically updated to reflect the committed changes.
joshuaspence awarded a token.Dec 21 2015, 12:01 AM
joshuaspence added a subscriber: joshuaspence.Dec 21 2015, 12:04 AM

I wonder if "capn" would be better as "cap'n".

src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
29

It would be slightly nicer to use double quotes instead to avoid escaping the inline single quote, i.e. "Capn's Tales".

hach-que added a subscriber: hach-que.Dec 21 2015, 11:05 AM
hach-que added inline comments.
src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php
57–60

Are these around the wrong way?

hach-que awarded a token.Dec 21 2015, 11:05 AM

Revision Contents
Changeset List

PathSize
src/
2 lines
infrastructure/
internationalization/
translation/
65 lines

Diff 35858

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/infrastructure/internationalization/translation/PhabricatorPirateEnglishTranslation.php

Loading...
Phabricator · Built by Phacility